Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: 0.100.3 -> 0.103.2 #76088

Merged
merged 5 commits into from Jan 9, 2020
Merged

home-assistant: 0.100.3 -> 0.103.2 #76088

merged 5 commits into from Jan 9, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 20, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from dotlambda and globin December 20, 2019 10:35
@Mic92
Copy link
Member Author

Mic92 commented Dec 20, 2019

cc @peterhoeg

@colemickens
Copy link
Member

I've cherry-picked and tested these changes. Works for me. Thanks!

@jonringer
Copy link
Contributor

related:
#75898
#74360
#74126
#70258
#70021

@Mic92
Copy link
Member Author

Mic92 commented Dec 21, 2019

@GrahamcOfBorg test home-assistant

@Mic92 Mic92 mentioned this pull request Dec 21, 2019
Closed
10 tasks
@Scriptkiddi
Copy link
Contributor

also related #75876

@ofborg ofborg bot removed the 6.topic: python label Jan 9, 2020
@Mic92
Copy link
Member Author

Mic92 commented Jan 9, 2020

Tests do not all work since there is a problem the authentication (I assume there is no user set up). However given that the package in master is broken anyway, this PR is still an improvement.

@Mic92 Mic92 mentioned this pull request Jan 9, 2020
Closed
10 tasks
@Mic92 Mic92 merged commit 5121edc into NixOS:master Jan 9, 2020
@Mic92 Mic92 deleted the hass branch January 9, 2020 11:29
@makefu
Copy link
Contributor

makefu commented Jan 10, 2020

great stuff, thanks!

@colemickens
Copy link
Member

Thanks for the work here. And a heads up, the new beta is back to building. I'll keep an eye and send a PR if someone doesn't beat me when they tag it as stable.

@jonringer jonringer mentioned this pull request Jan 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@dotlambda dotlambda Awaiting requested review from dotlambda

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Mic92 @colemickens @jonringer @Scriptkiddi @makefu @Br1ght0ne