Fix: Really check for start_date once an AI company slot becomes available. #7515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a hack to me. The better solution is to redo the whole start_date thing to be more sane, understandable and predictable - this start_date thing has come up far too often |
|
This pull request has been automatically marked as stale because it has not had any activity in the last month. |
|
The rework done in #7661 seems better to me, so I'm closing this PR. |
SamuXarick
deleted the
check-for-start_date-once-an-AI-company-slot-becomes-available
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically, if there's no slots, it checks daily, using the interval 3601 - 3600
and never reaches 0
if it gets a start_date lower than that 3601-3600 interval, then the real countdown starts, using that start_date value. When it reaches 0, it tries to make ai company