Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: 7.2.25 -> 7.2.26, 7.3.12 -> 7.3.13, 7.4.0 -> 7.4.1 #76132

Merged
merged 3 commits into from Dec 22, 2019
Merged

php: 7.2.25 -> 7.2.26, 7.3.12 -> 7.3.13, 7.4.0 -> 7.4.1 #76132

merged 3 commits into from Dec 22, 2019

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Dec 21, 2019 •
edited

Motivation for this change

Addresses several CVEs https://www.php.net/ChangeLog-7.php
closes #76019

See also #76133

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • nextcloud
  • php-pcre
  • wordpress
  • roundcube
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nix-review 1

127 package were build:
  • arcanist (matomo)
  • drush (matomo)
  • icingaweb2 (matomo)
  • kcachegrind (matomo)
  • lsp-plugins (matomo)
  • piwik (matomo)
  • matomo-beta (matomo)
  • nagios (matomo)
  • nextcloud-news-updater (matomo)
  • phoronix-test-suite (matomo)
  • php (matomo)
  • php-embed (matomo)
  • php-unit (matomo)
  • php73Packages-unit.apcu (matomo)
  • php73Packages-unit.apcu_bc (matomo)
  • php73Packages-unit.ast (matomo)
  • php73Packages-unit.box (matomo)
  • php73Packages-unit.composer (matomo)
  • php73Packages-unit.couchbase (matomo)
  • php73Packages-unit.event (matomo)
  • php73Packages-unit.igbinary (matomo)
  • php73Packages-unit.imagick (matomo)
  • php73Packages-unit.mailparse (matomo)
  • php73Packages-unit.maxminddb (matomo)
  • php73Packages-unit.memcached (matomo)
  • php73Packages-unit.mongodb (matomo)
  • php73Packages-unit.oci8 (matomo)
  • php73Packages-unit.pcov (matomo)
  • php73Packages-unit.pcs (matomo)
  • php73Packages-unit.pdo_sqlsrv (matomo)
  • php73Packages-unit.php-cs-fixer (matomo)
  • php73Packages-unit.php-parallel-lint (matomo)
  • php73Packages-unit.phpcbf (matomo)
  • php73Packages-unit.phpcs (matomo)
  • php73Packages-unit.phpstan (matomo)
  • php73Packages-unit.pinba (matomo)
  • php73Packages-unit.protobuf (matomo)
  • php73Packages-unit.psalm (matomo)
  • php73Packages-unit.redis (matomo)
  • php73Packages-unit.sqlsrv (matomo)
  • php73Packages-unit.xdebug (matomo)
  • php73Packages-unit.yaml (matomo)
  • php73Packages.apcu (matomo)
  • php73Packages.apcu_bc (matomo)
  • php73Packages.ast (matomo)
  • php73Packages.box (matomo)
  • php73Packages.composer (matomo)
  • php73Packages.couchbase (matomo)
  • php73Packages.event (matomo)
  • php73Packages.igbinary (matomo)
  • php73Packages.imagick (matomo)
  • php73Packages.mailparse (matomo)
  • php73Packages.maxminddb (matomo)
  • php73Packages.memcached (matomo)
  • php73Packages.mongodb (matomo)
  • php73Packages.oci8 (matomo)
  • php73Packages.pcov (matomo)
  • php73Packages.pcs (matomo)
  • php73Packages.pdo_sqlsrv (matomo)
  • php73Packages.php-cs-fixer (matomo)
  • php73Packages.php-parallel-lint (matomo)
  • php73Packages.phpcbf (matomo)
  • php73Packages.phpcs (matomo)
  • php73Packages.phpstan (matomo)
  • php73Packages.pinba (matomo)
  • php73Packages.protobuf (matomo)
  • php73Packages.psalm (matomo)
  • php73Packages.redis (matomo)
  • php73Packages.sqlsrv (matomo)
  • php73Packages.xdebug (matomo)
  • php73Packages.yaml (matomo)
  • php74 (matomo)
  • php74-embed (matomo)
  • php74-unit (matomo)
  • php74Packages-unit.apcu (matomo)
  • php74Packages-unit.apcu_bc (matomo)
  • php74Packages-unit.ast (matomo)
  • php74Packages-unit.box (matomo)
  • php74Packages-unit.composer (matomo)
  • php74Packages-unit.event (matomo)
  • php74Packages-unit.igbinary (matomo)
  • php74Packages-unit.imagick (matomo)
  • php74Packages-unit.mailparse (matomo)
  • php74Packages-unit.maxminddb (matomo)
  • php74Packages-unit.memcached (matomo)
  • php74Packages-unit.mongodb (matomo)
  • php74Packages-unit.oci8 (matomo)
  • php74Packages-unit.pcov (matomo)
  • php74Packages-unit.php-cs-fixer (matomo)
  • php74Packages-unit.php-parallel-lint (matomo)
  • php74Packages-unit.phpcbf (matomo)
  • php74Packages-unit.phpcs (matomo)
  • php74Packages-unit.phpstan (matomo)
  • php74Packages-unit.pinba (matomo)
  • php74Packages-unit.psalm (matomo)
  • php74Packages-unit.redis (matomo)
  • php74Packages-unit.xdebug (matomo)
  • php74Packages-unit.yaml (matomo)
  • php74Packages.apcu (matomo)
  • php74Packages.apcu_bc (matomo)
  • php74Packages.ast (matomo)
  • php74Packages.box (matomo)
  • php74Packages.composer (matomo)
  • php74Packages.event (matomo)
  • php74Packages.igbinary (matomo)
  • php74Packages.imagick (matomo)
  • php74Packages.mailparse (matomo)
  • php74Packages.maxminddb (matomo)
  • php74Packages.memcached (matomo)
  • php74Packages.mongodb (matomo)
  • php74Packages.oci8 (matomo)
  • php74Packages.pcov (matomo)
  • php74Packages.php-cs-fixer (matomo)
  • php74Packages.php-parallel-lint (matomo)
  • php74Packages.phpcbf (matomo)
  • php74Packages.phpcs (matomo)
  • php74Packages.phpstan (matomo)
  • php74Packages.pinba (matomo)
  • php74Packages.psalm (matomo)
  • php74Packages.redis (matomo)
  • php74Packages.xdebug (matomo)
  • php74Packages.yaml (matomo)
  • pulseeffects (matomo)
  • qcachegrind (matomo)
  • unit (matomo)
  • wp-cli (matomo)
  • yle-dl (matomo)

@ofborg ofborg bot requested a review from globin December 21, 2019 13:32
aanderse
aanderse approved these changes Dec 21, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markuskowa LGTM 👍 but do you want to include the 7.2 update in this PR while you're at it? Or keeping that separate as it isn't security related?

@aanderse
Copy link
Member

aanderse commented Dec 21, 2019 •
edited

@GrahamcOfBorg build php74

@markuskowa
Copy link
Member Author

Good point, forgot 7.2 here. I added an update for 7.2, since it also fixes fro CVEs.

@aanderse
Copy link
Member

@GrahamcOfBorg build php72
@GrahamcOfBorg build php74

@aanderse
Copy link
Member

Great! Thanks for adding.

@aanderse
Copy link
Member

Thanks @markuskowa!

@aanderse aanderse changed the title php: 7.3.12 -> 7.3.13, 7.4.0 -> 7.4.1 php: 7.2.25 -> 7.2.26, 7.3.12 -> 7.3.13, 7.4.0 -> 7.4.1 Dec 22, 2019
@aanderse aanderse merged commit 58d248c into NixOS:master Dec 22, 2019
@markuskowa markuskowa deleted the upd-php branch December 22, 2019 00:20
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Dec 24, 2019
@aanderse @dtzWill
Merge pull request NixOS#76132 from markuskowa/upd-php
05b716b 
php: 7.2.25 -> 7.2.26, 7.3.12 -> 7.3.13, 7.4.0 -> 7.4.1
(cherry picked from commit 58d248c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@etu etu Awaiting requested review from etu

@Izorkin Izorkin Awaiting requested review from Izorkin

@globin globin Awaiting requested review from globin globin is a code owner

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 79: php-7.3.12: 1 advisory
2 participants
@markuskowa @aanderse