Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages: 4.41.0 -> 4.51.1 #76111

Closed
wants to merge 1 commit into from

Conversation

Pamplemousse
Copy link
Member

Motivation for this change

A more recent version of the package is available.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
Notify maintainers

Added myself as a maintainer as there was none...

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message should be:

pythonPackages.hypothesis: 4.41.0 -> 4.51.1

you forgot the package name

@veprbl
Copy link
Member

veprbl commented Dec 21, 2019

Mass rebuild should target the staging branch.

@@ -9,7 +9,7 @@ buildPythonPackage rec {
# pytz fake_factory django numpy pytest
# If you need these, you can just add them to your environment.

version = "4.41.0";
version = "4.51.1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to update sha256.

@jonringer
Copy link
Contributor

this has already been introduced in #76059 likely to close :(

@jonringer
Copy link
Contributor

i would have cherry picked if the commit message had the package name, sorry :(

@Pamplemousse Pamplemousse deleted the hypothesis branch December 22, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants