Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/connman: optional iwd backend #76153

Merged
merged 1 commit into from Jan 2, 2020
Merged

nixos/connman: optional iwd backend #76153

merged 1 commit into from Jan 2, 2020

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Dec 21, 2019

Motivation for this change

connman supports it and the arch wiki claims it's more reliable. Fixes #56125.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27 Ma27 requested a review from ckauhaus December 22, 2019 23:38
ckauhaus
ckauhaus reviewed Dec 23, 2019
View reviewed changes
Copy link
Contributor

@ckauhaus ckauhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see immediate problems from visual inspection. But did not try it out due to the lack of an wifi-capable device running NixOS. Would someone please confirm that the code is working?

@arcnmx
Copy link
Member Author

arcnmx commented Dec 24, 2019

I've been using it on my laptop (Intel 7265NGW) since submitting this PR, and anecdotally haven't been having issues with wifi dropping out yet as it had been doing before the change.

@ckauhaus ckauhaus merged commit 129c738 into NixOS:master Jan 2, 2020
@arcnmx arcnmx deleted the connman-iwd branch November 26, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckauhaus ckauhaus ckauhaus left review comments

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using connman with iwd is impossible due to incorrect assertion
3 participants
@arcnmx @ckauhaus @Ma27