Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Systemd v243.4 #76134

Merged
merged 2 commits into from Jan 2, 2020
Merged

Systemd v243.4 #76134

merged 2 commits into from Jan 2, 2020

Conversation

lheckemann
Copy link
Member

closes #74207

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on NixOS
  • Tested via nixos/tests/timezone.nix

cc @flokli

@lheckemann lheckemann mentioned this pull request Dec 21, 2019
Closed
@lheckemann
Copy link
Member Author

Accompanying systemd PR: NixOS/systemd#34

@ofborg ofborg bot requested review from Mic92, edolstra, flokli and andir December 21, 2019 14:55
@nh2
Copy link
Contributor

nh2 commented Dec 22, 2019

You want master or should it be staging?

@lheckemann lheckemann changed the base branch from master to staging December 22, 2019 16:36
@lheckemann
Copy link
Member Author

Good catch, thanks.

@doronbehar
Copy link
Contributor

What was wrong with #74207 in the first place?

@flokli flokli mentioned this pull request Dec 27, 2019
Closed
10 tasks
@flokli
Copy link
Contributor

flokli commented Dec 27, 2019

#74207 broke the timezones-imperative test.

@FRidh FRidh added this to WIP in Staging via automation Dec 30, 2019
@FRidh FRidh moved this from WIP to Needs review in Staging Dec 30, 2019
flokli
flokli approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the timezone tests, switched my system to this systemd flavour, and toyed around with setting timezone via NixOS config and imperatively.

Staging automation moved this from Needs review to Ready Jan 2, 2020
@flokli flokli merged commit b33e1a6 into NixOS:staging Jan 2, 2020
Staging automation moved this from Ready to Done Jan 2, 2020
@lheckemann lheckemann deleted the systemd-v243.4 branch January 2, 2020 11:13
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 6, 2020
@flokli @dtzWill
Merge pull request NixOS#76134 from mayflower/systemd-v243.4
6e501b8 
Systemd v243.4

(cherry picked from commit b33e1a6)
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 6, 2020
@dtzWill
systemd: fix version after NixOS#76134
2376201
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 6, 2020
@dtzWill
systemd: fix version after update to 243.4 (NixOS#76134)
2fa60a6
flokli added a commit that referenced this pull request Jan 7, 2020
@flokli
Merge pull request #77137 from dtzWill/fix/systemd-243.4-version
2eb2fcc 
systemd: fix version after update to 243.4 (#76134)
flokli pushed a commit to flokli/nixpkgs that referenced this pull request Mar 11, 2020
@dtzWill @flokli
systemd: fix version after update to 243.4 (NixOS#76134)
794870a 
(cherry picked from commit 2fa60a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@edolstra edolstra Awaiting requested review from edolstra

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lheckemann @nh2 @doronbehar @flokli