This repository has been archived by the owner on Aug 6, 2020. It is now read-only.
forked from systemd/systemd
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lis3lv02d sensor used in many HP laptops is (almost) always intented primarily for freefall detection / HDD protection and (almost) always is located in the base of a classic clamshell laptop Before we had the ACCEL_LOCATION udev property the issues this caused with screen-rotation were fixed by applying a mount-matrix which translates base-coordinates to display-coordinates assuming the display is at an angle of exact 90 degrees to the base (swap Y and Z axis). The comment calls this translate "from "can play neverball" to "matches Windows 8 orientation"" but what it really does is translate base accel-axis to display accel-axis. Thus allows rotating the screen if you put the laptop on its side, but no-one normally does that with a 2Kg clamshell laptop. The obviously correct thing to do on classic clamshell laptops (not 2-in-1s) is to disable automatic screen rotation. This commit marks the accelerometer in these laptops as being part of the base, which will make iio-sensor-proxy disable automatic screen rotation. This commit also removes the orientation-matrix since the unmodified coordinates coming from the sensor are oriented correctly for a sensor in the base. Also see the "Bad accelerometer values cause incorrect screen rotation" systemd-devel mail-thread from September 2019.
Now that v243 is out, the script has been pulled by forks that are activated on Travis CI. As a result, all those forks have started to send their fuzzers to Fuzzit inadvertantly consuming our CPUs along the way. Let's prevent this by bailing out early if the script is run outside of the systemd repository.
The use of an unordered hashmap means that the output of 'journalctl --update-catalog' differs between runs despite there being no changes in the input files. By changing all instances of Hashmap to OrderedHashmap we fix this, and now the catalog is reproducible. Motivation: https://reproducible-builds.org Signed-off-by: Daniel Edgecumbe <git@esotericnonsense.com> (cherry picked from commit a95686b)
The memory is still needed in the sd_journal_sendv() after the 'if' block. (cherry picked from commit 1e19f5a)
(cherry picked from commit 0f93577)
Closes systemd#13516. (cherry picked from commit be71108)
Fixes RHBZ#1740664. (cherry picked from commit 5abba26)
(cherry picked from commit 20eef7c)
We matched "*Hewlett-Packard*" laptops but not "*HP*" laptops, which caused a regression for the HP Elite Book 850 G3. Fixes: 4247938 Closes: systemd#13543 (cherry picked from commit d7cf498)
systemd@b532843#commitcomment-34989175 (cherry picked from commit ff7cfff)
https://bugzilla.redhat.com/show_bug.cgi?id=1703598 (cherry picked from commit f731fd5)
(cherry picked from commit 4f6c727)
Follow-up for 12213ae. Closes systemd#13546. (cherry picked from commit bd9014c)
Fixes systemd#13518. (cherry picked from commit 067cc51)
(cherry picked from commit 48d26c9)
Resolves RHBZ #1743230 - journalctl dumps core when stack limit is reduced to 256 KB (cherry picked from commit f5e0b94)
relabel_extra() relabels the descendants of directories listed in relabel-extra.d, but doesn't relabel the files or directories explicitly named there. This makes it impossible to use relabel-extra.d to relabel the root of a filesystem. Fix by relabeling the named items too. (cherry picked from commit 71de684)
modified: tmpfiles.d/systemd.conf.m4 (cherry picked from commit d34a582)
The debug log making sense to the end user as an error. (cherry picked from commit 61cda4d)
(cherry picked from commit 6327aa9)
Commit a1c111c wrongly replaced '!' with ':' when the message is forwarded to wall(1). Indeed in this case we are not requesting the user for providing a password but instead we are simply displaying a message to suggest starting tty-ask-password-agent for providing the password. (cherry picked from commit 65943cc)
(cherry picked from commit b49e14d)
Before 25de7aa, the content is written by `fprintf()` without new line. So WRITE_STRING_FILE_AVOID_NEWLINE flag is necessary. Fixes systemd#13985. (cherry picked from commit a566ed2)
(cherry picked from commit 4b613ec)
(cherry picked from commit ffdc9c8)
During an add or change event, the device may be disconnected. Fixes systemd#13976. (cherry picked from commit b64b83d)
If udevd receives an exit signal, it releases its reference on the udev monitor in manager_exit(). If at this time a worker is hanging, and if the event timeout for this worker expires before udevd exits, udevd crashes in on_sigchld()->udev_monitor_send_device(), because the monitor has already been freed. Fix this by releasing the main process's monitor ref later, in manager_free(). (cherry picked from commit 7b6596d)
Fixes systemd#13756. We were returning things that didn't make much sense: we would always use the exit_code value as the exit code. But it sometimes contains a exit code from the process, and sometimes the number of a signal that was used to kill the process. We would also ignore SuccessExitStatus= and in general whether systemd thinks the service exited successfully (hence the issue in systemd#13756, where systemd would return success/SIGTERM, but we'd just look at the SIGTERM part.) If we are doing --wait, let's always propagate the exit code/status from the child. While at it, make the documentation useful. (cherry picked from commit 7f3614e)
In cases where the programs were modified after being initially declared, reorder operations so that the declaration is already in final form. (cherry picked from commit 2899aac)
On big endian arches, we were taking the wrong half-word, so the check was giving bogus results. https://bugzilla.redhat.com/show_bug.cgi?id=1769148. (cherry picked from commit 415fe5e)
We would jump one insn too many, landing in the middle of the subsequent block. (cherry picked from commit a72a532)
(cherry picked from commit bc9ecd4)
(cherry picked from commit 9193af0)
(cherry picked from commit 5322db0)
systemd-analyze verify command now results in segmentation fault if two consecutive non-existent unit file names are given: # ./build/systemd-analyze a.service b.service ...<snip irrelevant part>... Unit a.service not found. Unit b.service not found. Segmentation fault (core dumped) The cause of this is a wrong handling of return value of manager_load_startable_unit_or_warn() in verify_units() in failure case. It looks that the current logic wants to assign the first error status throughout verify_units() into variable r and count up variable count only when a given unit file exists. However, due to the wrong handling of the return value of manager_load_startable_unit_or_warn() in verify_units(), the variable count is unexpectedly incremented even when there is no such unit file because the variable r already contains non-zero value in the 2nd failure, set by the 1st failure, and then the condition k < 0 && r == 0 evaluates to false. This commit fixes the wrong handling of return value of manager_load_startable_unit_or_warn() in verify_units(). (cherry picked from commit fc9de36)
… or one Fixes systemd#13615. See the inline comment for documentation. (cherry picked from commit 32c6237)
(cherry picked from commit 1f6597a)
…and caching is enabled (cherry picked from commit e013e10)
If we fail to start polkit, we get a message like "org.freedesktop.DBus.Error.NameHasNoOwner: Could not activate remote peer.", which has no meaning for the caller of our StartUnit method. Let's just return -EACCES. $ systemctl start apache Failed to start apache.service: Could not activate remote peer. (before) Failed to start apache.service: Access denied (after) Fixes systemd#13865. (cherry picked from commit 7edd8fb)
It was only described in systemd(1), making it hard to discover. Fixes systemd#13561. The same for $SYSTEMD_URLIFY. I think all the tools whose man pages include less-variables.xml support those variables. (cherry picked from commit 339bf20)
… specified Makes the error output seen in systemd#13993 more readable. (cherry picked from commit f795267)
Kernels work without swap just fine. Fixes: systemd#13993 (cherry picked from commit 2cdd0d6)
Allow ConditionVirtualization=vmware to work on ESXi on arm VMs using device-tree. (cherry picked from commit 4d4ac92)
Fixes systemd#14060. (cherry picked from commit dc11d2b)
Closes systemd#14062. (cherry picked from commit f0beb6f)
Closes systemd#14002. (cherry picked from commit c9fdaed)
systemd-stable v243.3
systemd-stable v243.4 Adjusts timedated.c to use /etc/zoneinfo rather than /usr/share/zoneinfo.
3 tasks
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NixOS/nixpkgs#76134