Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flyway: 6.1.0 -> 6.1.2 #76094

Merged
merged 2 commits into from Dec 20, 2019
Merged

flyway: 6.1.0 -> 6.1.2 #76094

merged 2 commits into from Dec 20, 2019

Conversation

Rakesh4G
Copy link
Contributor

@Rakesh4G Rakesh4G commented Dec 20, 2019 •
edited

Motivation for this change

flyway: 6.1.0 -> 6.1.2
Fix for : jarDirs set by default to the proper location of share/flyway/jars
Related to #59687

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @CMCDragonkai

@Rakesh4G
Copy link
Contributor Author

Related to #59687

@ofborg ofborg bot requested a review from CMCDragonkai December 20, 2019 11:30
@Rakesh4G Rakesh4G changed the title jarDirs set by default to the proper location of share/flyway/jars flyway: 6.1.0 -> 6.1.2 Dec 20, 2019
@teto teto merged commit be98fd4 into NixOS:master Dec 20, 2019
@CMCDragonkai CMCDragonkai mentioned this pull request Dec 20, 2019
Closed
@Rakesh4G Rakesh4G deleted the flyway_fb branch December 21, 2019 05:15
jerith666 added a commit to jerith666/nixpkgs that referenced this pull request Jan 2, 2020
@jerith666
flyway: fix jarDirs option
2867d19 
this is not a system property, but rather an argument to
org.flaywaydb.commandline.Main.main().  therefore, it must come after,
rather than before, the name of the main class.  (otherwise it's
interpreted as an argument to the VM itself.)

flyway also expects the option and value to be separated by '=', not ' '.

follows on to NixOS#76094
@jerith666 jerith666 mentioned this pull request Jan 2, 2020
Merged
10 tasks
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 8, 2020
@jerith666 @dtzWill
flyway: fix jarDirs option
a22baec 
this is not a system property, but rather an argument to
org.flaywaydb.commandline.Main.main().  therefore, it must come after,
rather than before, the name of the main class.  (otherwise it's
interpreted as an argument to the VM itself.)

flyway also expects the option and value to be separated by '=', not ' '.

follows on to NixOS#76094

(cherry picked from commit 2867d19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CMCDragonkai CMCDragonkai Awaiting requested review from CMCDragonkai

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rakesh4G @teto