Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awscli: pin colorama to 0.4.1 #76092

Merged
merged 1 commit into from Dec 20, 2019
Merged

awscli: pin colorama to 0.4.1 #76092

merged 1 commit into from Dec 20, 2019

Conversation

terlar
Copy link
Contributor

@terlar terlar commented Dec 20, 2019

Later versions of colorama have removed support for EOL pythons.
This is why this has been pinned to 0.3.9 in the upstream awscli
package.

This fixes the currently broken expression for the awscli:

$ nix-build --no-build-output -A awscli
these derivations will be built:
  /nix/store/i07n9rhxvcj5ylah36i4q3gd05xyjc03-awscli-1.16.266.drv
building '/nix/store/i07n9rhxvcj5ylah36i4q3gd05xyjc03-awscli-1.16.266.drv'...
builder for '/nix/store/i07n9rhxvcj5ylah36i4q3gd05xyjc03-awscli-1.16.266.drv' failed with exit code 1; last 10 log lines:
  Finished executing setuptoolsBuildPhase
  installing
  Executing pipInstallPhase
  /build/awscli-1.16.266/dist /build/awscli-1.16.266
  Processing ./awscli-1.16.266-py2.py3-none-any.whl
  Requirement already satisfied: PyYAML<5.2,>=3.10 in /nix/store/gn0wy1wdz0n3pwgk14dynddw4bkgb5db-python3.7-PyYAML-5.1.2/lib/python3.7/site-packages (from awscli==1.16.266) (5.1.2)
  Requirement already satisfied: rsa<=3.5.0,>=3.1.2 in /nix/store/bx2m06rdgw46qms806pxv0nkriijq118-python3.7-rsa-3.4.2/lib/python3.7/site-packages (from awscli==1.16.266) (3.4.2)
  Requirement already satisfied: docutils<0.16,>=0.10 in /nix/store/lf18ijqmzalmvhr6nwg7lfysx5q024ma-python3.7-docutils-0.15.2/lib/python3.7/site-packages (from awscli==1.16.266) (0.15.2)
  ERROR: Could not find a version that satisfies the requirement colorama<0.4.2,>=0.2.5 (from awscli==1.16.266) (from versions: none)
  ERROR: No matching distribution found for colorama<0.4.2,>=0.2.5 (from awscli==1.16.266)
error: build of '/nix/store/i07n9rhxvcj5ylah36i4q3gd05xyjc03-awscli-1.16.266.drv' failed
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @muflax

LnL7
LnL7 approved these changes Dec 20, 2019
View reviewed changes
pkgs/tools/admin/awscli/default.nix Outdated
@@ -7,6 +7,13 @@
let
py = python3.override {
packageOverrides = self: super: {
colorama = super.colorama.overridePythonAttrs (oldAttrs: rec {
version = "0.3.9";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.4.1 would also be ok

Copy link
Contributor Author

@terlar terlar Dec 20, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, interesting, seems to work.

I was looking at the wrong place:
https://github.com/aws/aws-cli/blob/1.16.266/setup.py#L46
Instead of:
https://github.com/aws/aws-cli/blob/1.16.266/setup.py#L49

Will update to this, that explains why this didn't break until just recently, was a bit surprised as how to it was working up until now.

@terlar terlar changed the title awscli: pin colorama to 0.3.9 awscli: pin colorama to 0.4.1 Dec 20, 2019
@terlar
Copy link
Contributor Author

terlar commented Dec 20, 2019

@LnL7 thank you, I have updated it now

@terlar
awscli: pin colorama to 0.4.1
7a99d1e 
This is pinned to 0.4.1 in the upstream awscli package.
@LnL7 LnL7 merged commit 116ef2a into NixOS:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@terlar @LnL7