Win32: Drastically reduce stack usage at startup. NFC? #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default-initialization and list-aggregate-initialization are different. On a cursory check, System is POD, so default-initializing it would leave garbage inside. TextWindow is not, so it should be benign there. However, VS12 that we use for Appveyor builds could have bugs beyond this, so you should check that the CI-built binary works. |
|
The appveyor artifact runs on my Win10 64 machine, so does my locally compiled copy... but that does not mean much. |
ruevs
force-pushed
the
master
branch
2 times, most recently
from
4188cdf
to
56f139d
Compare
See: solvespace#92 (comment) The problem was first introduced here: solvespace@dabd578 and later "fixed" here: solvespace@f324477 by setting the stack size to /STACK:33554432 Solvespace now starts up even with /STACK:554432 According to this: https://en.cppreference.com/w/cpp/language/value_initialization ``` "2) if T is a class type with a default constructor that is neither user-provided nor deleted (that is, it may be a class with an implicitly-defined or defaulted default constructor), the object is zero-initialized and then it is default-initialized if it has a non-trivial default constructor; " ``` So removing the `{}` should leave both the `System` and `TextWindow` class instances properly initialized.
|
Merge? ;-) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
#92 (comment)
The problem was first introduced here:
dabd578
and later "fixed" here:
f324477
by setting the stack size to /STACK:33554432
Solvespace now starts up even with /STACK:554432
According to this:
https://en.cppreference.com/w/cpp/language/value_initialization
So removing the
{}should leave both theSystemandTextWindowclass instances properly initialized.