Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-snmp: split outputs #76155

Merged
merged 7 commits into from Dec 25, 2019
Merged

net-snmp: split outputs #76155

merged 7 commits into from Dec 25, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 21, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Mic92
Copy link
Member Author

Mic92 commented Dec 21, 2019

I tested all packages directly depending on net-snmp.

c0bw3b
c0bw3b reviewed Dec 22, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keepalived bump to v2.x requires a revamp of the associated service module too. See previous discussion in #72278 for example.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 22, 2019

cc @thoughtpolice for h2o, maybe the choice of building against libressl was deliberate?

@Mic92
Copy link
Member Author

Mic92 commented Dec 22, 2019 •
edited

dnsdist is the only package in nixpkgs that uses h2o and it already caused problems to mix ssl libraries.

@Mic92
Copy link
Member Author

Mic92 commented Dec 22, 2019

Keepalived works fine. Added a NixOS test.

@thoughtpolice
Copy link
Member

cc @thoughtpolice for h2o, maybe the choice of building against libressl was deliberate?

No, this was probably an error on my part, and it should be fine to change it.

@Mic92 Mic92 merged commit 89c55c0 into NixOS:master Dec 25, 2019
@Mic92 Mic92 deleted the net-snmp branch December 25, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @c0bw3b @thoughtpolice