Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtpass: Fix /usr/lib hardcode to pass-otp. #76113

Merged
merged 1 commit into from Dec 22, 2019
Merged

qtpass: Fix /usr/lib hardcode to pass-otp. #76113

merged 1 commit into from Dec 22, 2019

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Dec 20, 2019

Motivation for this change

Before, the checkbox for OTP functionality could not be enabled on NixOS, even when (pass.withExtensions (exts: [ exts.pass-otp ])) was installed correctly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @hrdinka

@nh2 nh2 requested a review from hrdinka December 20, 2019 21:34
@nh2
Copy link
Contributor Author

nh2 commented Dec 20, 2019

@GrahamcOfBorg build

@worldofpeace
Copy link
Contributor

You're missing the fetchpatch arg @nh2.

@nh2 nh2 force-pushed the qtpass-dont-hardcode-pass-otp-usr-lib branch from 20ebbb0 to a83fadc Compare December 22, 2019 02:09
@nh2
qtpass: Fix /usr/lib hardcode to pass-otp.
213e129 
Before, the checkbox for OTP functionality could not be enabled on
NixOS, even when `(pass.withExtensions (exts: [ exts.pass-otp ]))`
was installed correctly.
@nh2 nh2 force-pushed the qtpass-dont-hardcode-pass-otp-usr-lib branch from a83fadc to 213e129 Compare December 22, 2019 02:20
@nh2
Copy link
Contributor Author

nh2 commented Dec 22, 2019

@GrahamcOfBorg build

@worldofpeace worldofpeace merged commit 9f99517 into NixOS:master Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@hrdinka hrdinka Awaiting requested review from hrdinka

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @worldofpeace