[html] Test COEP derivation in shared workers #20899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for writing this! It would help if variable names were consistent. E.g., consistently refer to frame or owner for the frame. Now, it's not clear to me how you deal with the worker failing to load. If the owner/frame requires COEP and the worker does not, how is that handled? (Also, "default COEP" is not entirely clear to me, "without COEP" / "with COEP" or "none" / "require-corp" would be clearer.) I also think it'd be worth adding Hope that helps. |
zcorpan
reviewed
Jan 8, 2020
html/cross-origin-embedder-policy/resources/shared-worker-fetch.js.py
Outdated
Show resolved
Hide resolved
zcorpan
reviewed
Jan 8, 2020
16 tasks
zcorpan
force-pushed
the
html-coep-shared-worker-policy
branch
from
0ccd8b7
to
a77c21f
Compare
zcorpan
approved these changes
Jan 18, 2021
|
When #27226 is merged, I will rebase this PR again. |
zcorpan
force-pushed
the
html-coep-shared-worker-policy
branch
from
a77c21f
to
bc798de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be incorrect. I'm trying to verify that COEP is initialized according to the new algorithm for workers. I'm second-guessing myself because Chromium 78 fails the interesting cases: