Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pantheon cleanups #76116

Merged
merged 7 commits into from Dec 23, 2019
Merged

Pantheon cleanups #76116

merged 7 commits into from Dec 23, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Various things improving Pantheon superficially.
Prominently extraWingpanelIndicators and extraSwitchboardPlugs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg test pantheon

Also cleanup a bit, we enabled gnome-settings-daemon even when using elementary-settings-daemon.
I wanted the nixos module ascribe the defaults, not these lists in pkgs.
…end to defaults

Wingpanel was designed firstly as an indicator renderer,
and as such just a container for indicators that are distributed
outside itself. Being able to control which and each indicator with
`indicators` is confusing, ideally each of the default indicators
would be shipped with wingpanel itself. I don't see how this
kind of extensibility would be useful to a user so we're going
to append to the expected defaults. The `useDefaultIndicators`
argument is there to development test a single indicator/s.
…efaults

Switchboard was designed identically to Wingpanel, so the same justification
stands here.
@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg test pantheon

@worldofpeace
Copy link
Contributor Author

Tested on aarch64-linux without failure.

@worldofpeace worldofpeace merged commit 35b7b17 into NixOS:master Dec 23, 2019
@worldofpeace worldofpeace deleted the pantheon-cleanup branch December 23, 2019 03:59
@worldofpeace worldofpeace mentioned this pull request Dec 23, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant