New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pantheon cleanups #76116
Merged
Merged
Pantheon cleanups #76116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: nixos
6.topic: pantheon
The Pantheon desktop environment
8.has: module (update)
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
Dec 21, 2019
@GrahamcOfBorg test pantheon |
Also cleanup a bit, we enabled gnome-settings-daemon even when using elementary-settings-daemon. I wanted the nixos module ascribe the defaults, not these lists in pkgs.
…end to defaults Wingpanel was designed firstly as an indicator renderer, and as such just a container for indicators that are distributed outside itself. Being able to control which and each indicator with `indicators` is confusing, ideally each of the default indicators would be shipped with wingpanel itself. I don't see how this kind of extensibility would be useful to a user so we're going to append to the expected defaults. The `useDefaultIndicators` argument is there to development test a single indicator/s.
…efaults Switchboard was designed identically to Wingpanel, so the same justification stands here.
worldofpeace
force-pushed
the
pantheon-cleanup
branch
from
December 22, 2019 04:08
29f0503
to
016c589
Compare
@GrahamcOfBorg test pantheon |
Tested on aarch64-linux without failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
6.topic: pantheon
The Pantheon desktop environment
8.has: module (update)
10.rebuild-darwin: 0
10.rebuild-linux: 0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Various things improving Pantheon superficially.
Prominently
extraWingpanelIndicators
andextraSwitchboardPlugs
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @