rust-9p: init #76117
Merged
rust-9p: init #76117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssais
reviewed
Dec 21, 2019
pkgs/servers/rust-9p/default.nix
Outdated
| @@ -0,0 +1,36 @@ | |||
| { | |||
| stdenv, fetchFromGitHub, rust | |||
| }: | |||
There was a problem hiding this comment.
Should be one line: https://nixos.org/nixpkgs/manual/#sec-syntax
7c6f434c
force-pushed
the
add-rust-9p
branch
from
c48763d
to
b839448
Compare
alyssais
requested changes
Dec 21, 2019
pkgs/servers/rust-9p/default.nix
Outdated
| meta = with stdenv.lib; { | ||
| description = "9P2000.L server implementation in Rust"; | ||
| homepage = "https://github.com/pfpacket/rust-9p"; | ||
| license = with licenses; [ bsd3 ]; |
There was a problem hiding this comment.
Suggested change
| license = with licenses; [ bsd3 ]; | |
| license = licenses.bsd3; |
I think we usually only use a list for multiple licenses.
pkgs/servers/rust-9p/default.nix
Outdated
| maintainers = with maintainers; [ raskin ]; | ||
|
|
||
| # macOS build fails: https://github.com/pfpacket/rust-9p/issues/7 | ||
| platforms = with platforms; linux; |
There was a problem hiding this comment.
There’s nothing that makes macOS intrinsically unsupported, so I think this should be
Suggested change
| platforms = with platforms; linux; | |
| platforms = platforms.unix; |
There was a problem hiding this comment.
No version of upstream code has ever worked on any version of macOS, as far as I understand. We need either broken or platform limitation, and I think platform limitation is fine in this case.
pkgs/servers/rust-9p/default.nix
Outdated
|
|
||
| cargoSha256 = "1d33nwj3i333a6ji3r3037mgg553lc3wsawm0pz13kbvhjf336i8"; | ||
|
|
||
| RUSTC_BOOTSTRAP=1; |
There was a problem hiding this comment.
Suggested change
| RUSTC_BOOTSTRAP=1; | |
| RUSTC_BOOTSTRAP = 1; |
7c6f434c
force-pushed
the
add-rust-9p
branch
from
b839448
to
147d414
Compare
|
Should the package be called unpfs? rust-9p seems to be more of the
name of the library.
|
7c6f434c
force-pushed
the
add-rust-9p
branch
from
147d414
to
853953a
Compare
|
Should the package be called unpfs? rust-9p seems to be more of the
name of the library.
Indeed; when I started the packaging I thought that packaing rust-9p in
a way that allows its use as a libary, too, would be straightforward.
|
alyssais
pushed a commit
to alyssais/nixpkgs
that referenced
this pull request
May 7, 2020
(cherry-picked from NixOS#76117)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A Rust-based implementation of 9p2000.L, seems more trustable than C-based diod
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify
cc @qyliss