Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pscid: init at 2.8.5 #76125

Merged
merged 1 commit into from Dec 22, 2019
Merged

pscid: init at 2.8.5 #76125

merged 1 commit into from Dec 22, 2019

Conversation

cdepillabout
Copy link
Member

Motivation for this change

Add pscid, a build tool for PureScript, to the nodePackages package set.

Things done

I ran pkgs/development/node-packages/generate.sh, let it regenerate everything, and removed all changes that seemed unrelated to pscid in the node-10 package set.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

turboMaCk
turboMaCk approved these changes Dec 21, 2019
View reviewed changes
Copy link
Member

@turboMaCk turboMaCk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds on NixOS, "binary" works, LGTM

@cdepillabout cdepillabout merged commit 88691a9 into NixOS:master Dec 22, 2019
@cdepillabout cdepillabout deleted the add-pscid branch December 22, 2019 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turboMaCk turboMaCk turboMaCk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdepillabout @turboMaCk