Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.spacy: 2.2.0 -> 2.2.1 #70333

Merged
merged 2 commits into from Oct 3, 2019
Merged

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Oct 3, 2019

Motivation for this change

Bugfix update to spaCy 2.2.0. One change fixes the tag mapping for Dutch. This also requires an updated model for Dutch, which is in the second commit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Changes:

* Vectors.most_similar returns the top most similar vectors instead
  only one.
* Fixes tag map in Dutch model.
* Fix initialization of DocBin with attributes.
@jonringer
Copy link
Contributor

how does this play with the large model update you did?

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
patch
spacy executable seems to still work

https://github.com/NixOS/nixpkgs/pull/70333
2 package were build:
python37Packages.spacy python37Packages.textacy

@jonringer jonringer merged commit 4c37faa into NixOS:master Oct 3, 2019
@danieldk
Copy link
Contributor Author

danieldk commented Oct 3, 2019

how does this play with the large model update you did?

The model update updated all models to version 2.2.0. However, there was a bug in spaCy for Dutch, which requires updating just this model to version 2.2.1 (the other models are still at 2.2.0).

@jonringer
Copy link
Contributor

I came to that realization, and just merged xD

@danieldk danieldk deleted the spacy-2.2.1 branch July 6, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants