Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opera: use autoPatchelfHook, use wrapGAppsHook #70329

Merged
merged 1 commit into from Oct 3, 2019
Merged

opera: use autoPatchelfHook, use wrapGAppsHook #70329

merged 1 commit into from Oct 3, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fixes #70322

Things done

I've done the steps to reproduce in the issue

Open the Extensions page by navigating to chrome://extensions, enable Developer mode then Load unpacked to select an extension directory.

Making sure to run the binary in a shell with unset XDG_DATA_DIRS and there's no crash.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 3, 2019
jonringer
jonringer approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passe on NixOS
diff LGTM
opera works (been a long time since I've seen it, lol)
leaf package

[3 built, 3 copied (0.8 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70329
1 package were build:
opera

[nix-shell:/home/jon/.cache/nix-review/pr-70329]$ nix path-info -Sh ./results/opera
/nix/store/9ccgc09y2491dxxcdf235zjzk1k5zrx8-opera-62.0.3331.43   526.7M
[09:05:10] jon@jon-desktop /home/jon/projects/nixpkgs (master)
$ nix path-info -Sh ./result
/nix/store/vhw3d97k09y1hbq5fcgz962pwddflpqk-opera-62.0.3331.43   522.2M

@worldofpeace worldofpeace merged commit 2d9eb21 into NixOS:master Oct 3, 2019
@worldofpeace worldofpeace deleted the wrapgapps-opera branch October 3, 2019 16:09
@worldofpeace
Copy link
Contributor Author

backported in 3ba0d9f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opera constantly crashes
2 participants
@worldofpeace @jonringer