gaia: init at 2.4.5 #70372
gaia: init at 2.4.5 #70372
Conversation
There was a problem hiding this comment.
Thanks for all the comments @aszlig, I've commented as well and pushed changes.
Use pythonPackages instead of just python and add an attribute to python-packages.nix.
doronbehar
force-pushed
the
package-gaia
branch
from
fbfd277
to
a246b74
Compare
There was a problem hiding this comment.
Thanks @aszlig for the comments, I've pushed a working build including a disable for Python3.
| substituteInPlace src/wscript \ | ||
| --replace "/etc/cyclops" "$out/etc/cyclops" \ | ||
| --replace "/etc/init.d" "$out/etc/init.d" | ||
| ''; |
There was a problem hiding this comment.
BTW @aszlig, what do you think about the fact the package installs init.d files? I've had a look at these files today and I noticed they refer to paths which rely upon the fact the system will comply to the FHS hierarchy. Patching them might require some work. I wouldn't mind dive into it but NixOS doesn't even use these init files so what would be the point of that? Should we provide systemd files that will provide the same functionality? TBH I don't even know what these daemons are for and I've never used them not I intend to. Maybe we can keep it as is so future users of this package will be able to look at them for reference?
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/71 |
|
Thanks @matthewbauer! Now that this is merged, could you please take a look at #70389? |
gaia: init at 2.4.5 (cherry picked from commit 5dfbfc0)
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @