Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gaia: init at 2.4.5 #70372

Merged
merged 8 commits into from
Nov 7, 2019
Merged

gaia: init at 2.4.5 #70372

merged 8 commits into from
Nov 7, 2019
+93 −0

Conversation

doronbehar
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@doronbehar
gaia: init at 2.4.5

Verified

This commit was signed with the committer’s verified signature.
vcunat Vladimír Čunát
GPG key ID: E747DF1F9575A3AA
Verified
Learn about vigilant mode
e86ef91
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 4, 2019
This was referenced Oct 4, 2019
Closed
Closed
@doronbehar doronbehar requested a review from FRidh as a code owner October 5, 2019 06:44
doronbehar
doronbehar commented Oct 5, 2019
View reviewed changes
Copy link
Contributor Author

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the comments @aszlig, I've commented as well and pushed changes.

@doronbehar
Improve pythonSupport handling
a246b74 
Use pythonPackages instead of just python and add an attribute to
python-packages.nix.
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Oct 5, 2019
doronbehar
doronbehar commented Oct 8, 2019
View reviewed changes
Copy link
Contributor Author

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aszlig for the comments, I've pushed a working build including a disable for Python3.

doronbehar
doronbehar commented Oct 8, 2019
View reviewed changes
pkgs/development/libraries/gaia/default.nix
substituteInPlace src/wscript \
--replace "/etc/cyclops" "$out/etc/cyclops" \
--replace "/etc/init.d" "$out/etc/init.d"
'';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW @aszlig, what do you think about the fact the package installs init.d files? I've had a look at these files today and I noticed they refer to paths which rely upon the fact the system will comply to the FHS hierarchy. Patching them might require some work. I wouldn't mind dive into it but NixOS doesn't even use these init files so what would be the point of that? Should we provide systemd files that will provide the same functionality? TBH I don't even know what these daemons are for and I've never used them not I intend to. Maybe we can keep it as is so future users of this package will be able to look at them for reference?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/71

@matthewbauer matthewbauer merged commit 5dfbfc0 into NixOS:master Nov 7, 2019
@doronbehar
Copy link
Contributor Author

Thanks @matthewbauer! Now that this is merged, could you please take a look at #70389?

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
@matthewbauer @dtzWill
Merge pull request NixOS#70372 from doronbehar/package-gaia
ea65b4a 
gaia: init at 2.4.5
(cherry picked from commit 5dfbfc0)
@doronbehar doronbehar deleted the package-gaia branch March 2, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aszlig aszlig

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@doronbehar @nixos-discourse @aszlig @matthewbauer