Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpcap, tcpdump: 1.9.1 and 4.9.3 for many security fixes #70249

Merged
merged 2 commits into from Oct 7, 2019
Merged

libpcap, tcpdump: 1.9.1 and 4.9.3 for many security fixes #70249

merged 2 commits into from Oct 7, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 2, 2019

Motivation for this change

See linked notes for CVE's and other changes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from fpletz and globin October 2, 2019 12:52
tobim
tobim suggested changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tcpdump executable works, didn't do any real testing though.

pkgs/tools/networking/tcpdump/default.nix Show resolved Hide resolved
@dtzWill dtzWill changed the base branch from master to staging October 7, 2019 23:43
@dtzWill dtzWill force-pushed the update/pcap-tcpdump-security-2019 branch from f097d44 to dd42253 Compare October 7, 2019 23:45
@dtzWill dtzWill merged commit 5935d5a into NixOS:staging Oct 7, 2019
@dtzWill dtzWill deleted the update/pcap-tcpdump-security-2019 branch October 7, 2019 23:46
@risicle risicle mentioned this pull request Oct 26, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim requested changes

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @tobim