Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libbfd: use zlib.dev as input #70247

Merged
merged 1 commit into from Oct 2, 2019
Merged

libbfd: use zlib.dev as input #70247

merged 1 commit into from Oct 2, 2019

Conversation

nmattia
Copy link
Contributor

@nmattia nmattia commented Oct 2, 2019

Motivation for this change

The libbfd build was failing on pkgsStatic.

Before:

libbfd  linux  pkgs        success
libbfd  linux  pkgsStatic  failure

After:

libbfd  linux  pkgs        success
libbfd  linux  pkgsStatic  success
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @basvandijk

@basvandijk
Copy link
Member

@GrahamcOfBorg build libbfd pkgsStatic.libbfd

@jwiegley jwiegley merged commit 133eb42 into NixOS:master Oct 2, 2019
@nmattia nmattia deleted the nm-fix-libbfd-static branch October 2, 2019 16:01
@matthewbauer
Copy link
Member

Anyone know why this is necessary? I thought this would be automatically chosen by mkDerivation.

@Ericson2314
Copy link
Member

Yeah this shouldn't be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwiegley jwiegley jwiegley approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nmattia @basvandijk @matthewbauer @Ericson2314 @jwiegley