Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Synapse plugins, add matrix-synapse-pam #70327

Merged
merged 4 commits into from
Jun 9, 2020
Merged

Refactor Synapse plugins, add matrix-synapse-pam #70327

merged 4 commits into from
Jun 9, 2020
+84 −20

Conversation

abbradar
Copy link
Member

@abbradar abbradar commented Oct 3, 2019

Motivation for this change

Avoid having the core server depend on plugins. Also introduce a new one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@abbradar abbradar requested a review from FRidh as a code owner October 3, 2019 14:15
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package labels Oct 3, 2019
@ofborg ofborg bot requested review from Ralith, Ekleog and pacien October 3, 2019 14:37
@Ralith
Copy link
Contributor

Ralith commented Oct 4, 2019

Haven't had time to test, but seems like a good idea.

pacien
pacien reviewed Oct 5, 2019
View reviewed changes
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
zimbatm
zimbatm reviewed Jun 1, 2020
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good idea

@zimbatm zimbatm requested a review from jonringer as a code owner June 1, 2020 08:06
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 1, 2020
@zimbatm zimbatm force-pushed the synapse-plugins branch from ba01602 to fbf8e61 Compare June 1, 2020 08:23
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 1, 2020
@zimbatm zimbatm force-pushed the synapse-plugins branch from fbf8e61 to cd92184 Compare June 1, 2020 08:30
@zimbatm
Copy link
Member

zimbatm commented Jun 1, 2020

cleaned-up the PR a bit. It should be good to go.

@ofborg ofborg bot requested a review from Ma27 June 1, 2020 08:38
@ofborg ofborg bot requested a review from pacien June 1, 2020 08:38
@zimbatm zimbatm merged commit 9494fde into NixOS:master Jun 9, 2020
@ajs124
Copy link
Member

ajs124 commented Jun 12, 2020

There's a typo in plugins.exampleText.

"with config.services.matrix-synapse.package.plugins [ matrix-synapse-ldap3 matrix-synapse-pam ]";
should be
"with config.services.matrix-synapse.package.plugins; [ matrix-synapse-ldap3 matrix-synapse-pam ]";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm

@pacien pacien

@FRidh FRidh

@Ralith Ralith

@Ekleog Ekleog

@jonringer jonringer

@Ma27 Ma27

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@abbradar @Ralith @zimbatm @ajs124 @pacien