Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk3: correct version in .pc file #70323

Merged
merged 1 commit into from Oct 3, 2019

Conversation

worldofpeace
Copy link
Contributor

They forgot to bump meson project version.

Motivation for this change

Fixes #70308

Cc @jtojnar @hedning

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg build ocamlPackages.lablgtk3

@jtojnar
Copy link
Contributor

jtojnar commented Oct 3, 2019

Ouch. Should not this go to staging? Does it break anything else than lablgtk3? I am surprised something depends on such a recent version.

@worldofpeace
Copy link
Contributor Author

@jtojnar Yeah it should go to staging.

I didn't notice any other breakages so I think we might be fine.
Will check on hydra though.

@worldofpeace
Copy link
Contributor Author

Will check on hydra though.

Actually we ran these changes through the gnome-3.34 jobset and didn't notice much breaking.
So the impact was clearly small.

They forgot to bump meson project version.
@worldofpeace worldofpeace changed the base branch from master to staging October 3, 2019 19:11
@worldofpeace worldofpeace merged commit de87dbf into NixOS:staging Oct 3, 2019
@worldofpeace worldofpeace deleted the gtk-fix-pc branch October 3, 2019 19:12
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: printing labels Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants