NetworkManager, ModemManager: move all symlinks to alias, add alias for modem-manager.service #70325
Conversation
worldofpeace
added
the
9.needs: port to stable
|
I'd say this is pretty important for a release critical component. |
| "dbus-org.freedesktop.NetworkManager.service" | ||
| # Add the legacy service name from before #51382 to prevent NetworkManager | ||
| # from not starting back up: | ||
| # TODO: remove this once 19.09 is released |
There was a problem hiding this comment.
Any reason not to remove this in master as we've forked off 19.09?
There was a problem hiding this comment.
Hmm, I think we might actually have to remove it during 20.03 branching off.
Still a possibility we could cause an issue for a unstable user?
There was a problem hiding this comment.
Hmm, right, so that would be for people upgrading from 18.09 -> 20.03 with switch?
Still a possibility we could cause an issue for a unstable user?
Not entirely sure. But it's there to handle rebuild switch from legacy-name to new config with upstream name. So unstable users should have the upstream name already?
There was a problem hiding this comment.
Not entirely sure. But it's there to handle rebuild switch from legacy-name to new config with upstream name. So unstable users should have the upstream name already?
Now that I think about it, making guarantees like this for unstable doesn't seem right.
We just want to make sure that rebuild switching from 19.03 -> 19.09 works fine.
I'm not sure if 18.09 -> 19.03 would be a seamless switch.
We removed the symlinks for the alias in * f99bdb2 but we also need to move this definition into the module. Else we get issues like NixOS#70301. Fixes NixOS#70301.
We probably need this as well.
worldofpeace
force-pushed
the
networkmanager-no-symlinks-ever
branch
from
bb04483
to
33b705b
Compare
worldofpeace
requested review from
alyssais,
basvandijk,
Ericson2314,
FRidh,
infinisil and
joachifm
as code owners
ofborg
bot
added
8.has: changelog
8.has: documentation
2.status: merge conflict
and removed
6.topic: TeX
|
Realized that I already dropped the legacy service in staging |
|
@worldofpeace this means, this PR isn't needed for master/unstable? |
Yeah, I've re-targeted this to Not sure what's up with the commit graph here... |
Motivation for this change
Thinking this fixes #70301
I haven't tested this, but we need to make sure there's no issues with NetworkManager and users
doing
nixos-rebuild switch --upgrade.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)