Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible: version bump for 2.6/2.7 and current 2.8 #70326

Closed
wants to merge 2 commits into from
Closed

Ansible: version bump for 2.6/2.7 and current 2.8 #70326

wants to merge 2 commits into from

Conversation

derchrisuk
Copy link
Contributor

Motivation for this change

Version upgrade

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @joamaki @costrouc

@derchrisuk derchrisuk requested a review from FRidh as a code owner October 3, 2019 14:14
@ofborg ofborg bot requested a review from costrouc October 3, 2019 14:28
jonringer
jonringer approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
ansible* executables seem to work and are wrapped properly

[17 built, 5 copied (25.6 MiB), 5.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70326
13 package were build:
ansible ansible-lint ansible_2_6 ansible_2_7 kargo python27Packages.ansible python27Packages.ansible-kernel python27Packages.ansible-lint python27Packages.ansible-runner python27Packages.pytest-ansible python37Packages.ansible-kernel python37Packages.ansible-runner python37Packages.pytest-ansible

@jonringer
Copy link
Contributor

@GrahamcOfBorg build ansible ansible-lint ansible_2_6 ansible_2_7 kargo python27Packages.ansible python27Packages.ansible-kernel python27Packages.ansible-lint python27Packages.ansible-runner python27Packages.pytest-ansible python37Packages.ansible-kernel python37Packages.ansible-runner python37Packages.pytest-ansible

@jonringer jonringer mentioned this pull request Jan 9, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@derchrisuk @jonringer