Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup some glib/gtk vala FTBFS #70344

Merged
merged 9 commits into from
Oct 3, 2019
Merged

Fixup some glib/gtk vala FTBFS #70344

merged 9 commits into from
Oct 3, 2019
+39 −23

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Found a couple stragglers.

@romildo It appears that deepin-mutter and deepin-wm are not defunct upstream.
And deepin-mutter currently fails to build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@jtojnar
Copy link
Member

jtojnar commented Oct 3, 2019

While at it, can you rename the font-manager homepage to https://github.com/FontManager/font-manager

@worldofpeace
Copy link
Contributor Author

Here's the issue with deepin-terminal

Wasn't sure if that was the upstream xcb.vapi that had problems.

@ofborg ofborg bot requested review from pSub, romildo, jchv, peti and dtzWill October 3, 2019 19:22
@worldofpeace
Copy link
Contributor Author

While at it, can you rename the font-manager homepage to https://github.com/FontManager/font-manager

We're actually using the pointless repositories.git attribute here.
And the actual homepage has a convenient link to the source repo.

I think I'll just remove the repositories.git.

hedning
hedning approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace worldofpeace merged commit 6dbb7b2 into NixOS:master Oct 3, 2019
@worldofpeace worldofpeace deleted the fix-some-stuff branch October 3, 2019 22:13
@jtojnar jtojnar mentioned this pull request Jun 18, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

@hedning hedning

@pSub pSub

@romildo romildo

@jchv jchv

@peti peti

@dtzWill dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @jtojnar @hedning