Fixup some glib/gtk vala FTBFS #70344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While at it, can you rename the font-manager homepage to https://github.com/FontManager/font-manager |
|
Here's the issue with deepin-terminal Wasn't sure if that was the upstream xcb.vapi that had problems. |
jtojnar
reviewed
Oct 3, 2019
We're actually using the pointless I think I'll just remove the |
There appears to be issues with the xcb.vapi Seeing errors like xcb.vapi:411.3-411.48: error: missing return statement at end of subroutine body
worldofpeace
force-pushed
the
fix-some-stuff
branch
from
2dd0567
to
4631a07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Found a couple stragglers.
@romildo It appears that
deepin-mutteranddeepin-wmare not defunct upstream.And
deepin-muttercurrently fails to build.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @