I don't think it's a good idea to accept this with the dconf specific generation code in this module.

It would need to be abstracted to #54150.

@worldofpeace @jtojnar I've disabled dconf handling for now

@worldofpeace I plan to add support for gtk2 and qt4 (e.g. GIMP still uses gtk2 and we still have qt4 packages), it will be probably simpler to keep it in one place then

We could rename the qt5 module qt.

I think this module appears cluttered when we're handling different concepts of theming in two different toolkits.

@worldofpeace Ok, I will try to add qt4 and gtk2 support and then break this into qt5.nix and new gtk module

@jtojnar I think this module would solve the confusion about us directing people to "install an icon theme". Now there's a declarative way for this to happen. Us lacking an interface like this is why I think its been confusing. Having profiles (not sure if default ones are needed at all) would also make the base freedesktop config simple to expose.

@gnidorah I think it might be easier to extend the existing qt5 module to support those other settings, and then after this qt4. I'm pretty sure the gtk side of things would be completely blocked by #54150, but I think the changes for qt could be perfectly fine now.

@jtojnar @worldofpeace

install an icon theme

And widget style with color scheme what's more important.

I think it might be easier to extend the existing qt5 module to support those other settings, and then after this qt4

Why not hold both into qt.nix? There will be too few qt4 settings.

I'm pretty sure the gtk side of things would be completely blocked by #54150

No, not competely. They work fine with ini files until you use Wayland, only in that case you need dconf handling.

I'd prefer if we could keep the PR smaller and not have any defaults like that yet.
Things like this aren't managed declaratively yet, so it might make the feature more difficult to land.

I can do this through separate PR. Actually I think that what most need from this feature. Not to customize everything by own, but choose from default themes. Few people have pure Qt or pure Gtk stack, most have mixed stack of programs, in that case there is no unified look by default.
https://wiki.archlinux.org/index.php/Uniform_look_for_Qt_and_GTK_applications

BTW I will continue with in new PR

install an icon theme

And widget style with color scheme what's more important.

That particular comment was gtk related since there's been a running discussion on how to handle this issue.

I'll try to link some of that discussion here for reference

• doc: add GNOME #43150 (comment)
• gtk3.setupHook: clear icon-theme.cache in preFixup #68552

And I guess the documentation that came out of those discussions, and any recent reports on issues with icon themes.

I think it might be easier to extend the existing qt5 module to support those other settings, and then after this qt4

Why not hold both into qt.nix? There will be too few qt4 settings.

Oops, sorry if that came off confusing.
I was thinking of it as a breakdown of changes for one PR.
So like

Extend qt5 theming support
Rename to qt
Support theming qt4

I can do this through separate PR. Actually I think that what most need from this feature. Not to customize everything by own, but choose from default themes. Few people have pure Qt or pure Gtk stack, most have mixed stack of programs, in that case there is no unified look by default.

Exactly it's preferential. Though I totally wouldn't be opposed to having nice unified defaults, it's just we really lack a way to determine if something is a "desktop" in nixos to make those kind of decisions.
Though if we provide all the "knobs" to turn to have that it shouldn't be a problem.

@worldofpeace Continued in #71079