Update UI when changing input's value with setAttribute #19498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 3, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1834647
branch
3 times, most recently
from
d47aa84
to
ec9b923
Compare
This patch fixes a bug where setting a range input element's default
value with setAttribute('value', defaultValue) does not update the UI of
the range input to show the new default value.
The bug is present in WebKit, but not present in Firefox.
Bug: 852938
Change-Id: Ibef8c0c6cefeb221a0d9220a966b04a03d815c76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834647
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704667}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1834647
branch
from
ec9b923
to
91ef342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug where setting a range input element's default
value with setAttribute('value', defaultValue) does not update the UI of
the range input to show the new default value.
The bug is present in WebKit, but not present in Firefox.
Bug: 852938
Change-Id: Ibef8c0c6cefeb221a0d9220a966b04a03d815c76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834647
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704667}