Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soulseekqt: fix build #70298

Merged
merged 1 commit into from Nov 7, 2019
Merged

soulseekqt: fix build #70298

merged 1 commit into from Nov 7, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

saw it was broken while doing a review of #70235

  • updated the urls
  • fixed the qt runtime
  • cleaned up the expression a bit.

would like for a user to verify that the app doesn't do any dlopen's to libraries I removed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

$ nix path-info -Sh ./result
/nix/store/yqb1k52v822qpffh1xc7fiic8ykzds5l-soulseekqt-2018-1-30         310.0M

@jonringer
soulseekqt: fix build
c83aaba 
- Previous url returned a 404
- Updated expression to use new Qt utilities
- Cleaned up expression
@matthewbauer matthewbauer merged commit a9e9379 into NixOS:master Nov 7, 2019
@jonringer jonringer deleted the fix-soulseekqt branch February 13, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @matthewbauer