Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rssguard: Add wrapQtAppsHook to run app in all environments. #70281

Merged
merged 1 commit into from Nov 29, 2019
Merged

rssguard: Add wrapQtAppsHook to run app in all environments. #70281

merged 1 commit into from Nov 29, 2019

Conversation

pstn
Copy link
Contributor

@pstn pstn commented Oct 2, 2019

Motivation for this change

Qt app was not properly wrapped

Things done

Wrapped app with wrapQtAppsHook

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jluttine

@ofborg ofborg bot requested a review from jluttine October 2, 2019 21:34
jluttine
jluttine approved these changes Oct 13, 2019
View reviewed changes
Copy link
Member

@jluttine jluttine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, rssguard is currently broken and this PR fixes it. I tested by building and running the executable. So, looks good to me. Thanks! 👍

@c0bw3b c0bw3b merged commit fcd0ea3 into NixOS:master Nov 29, 2019
c0bw3b pushed a commit that referenced this pull request Nov 29, 2019
@c0bw3b
rssguard: add wrapQtAppsHook to run app in all environments
04afa99 
Backport of #70281

(cherry picked from commit fcd0ea3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jluttine jluttine jluttine approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pstn @jluttine @c0bw3b