Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spark: 2.4.3 -> 2.4.4; remove 1.6.3 (EOL); clean up #70280

Merged
merged 1 commit into from Oct 7, 2019
Merged

spark: 2.4.3 -> 2.4.4; remove 1.6.3 (EOL); clean up #70280

merged 1 commit into from Oct 7, 2019

Conversation

cko
Copy link
Member

@cko cko commented Oct 2, 2019

Motivation for this change
  • Update: 2.4.3 -> 2.4.4
  • Removing outdated 1.6.3 (EOL)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice @offline @kamilchm

@thoughtpolice thoughtpolice merged commit 036ed5d into NixOS:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@kamilchm kamilchm Awaiting requested review from kamilchm

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cko @thoughtpolice