Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tdesktop: 1.8.9 -> 1.8.13, range-v3: 0.5.0 -> 0.9.1 #70414

Merged
merged 2 commits into from Oct 4, 2019
Merged

tdesktop: 1.8.9 -> 1.8.13, range-v3: 0.5.0 -> 0.9.1 #70414

merged 2 commits into from Oct 4, 2019

Conversation

primeos
Copy link
Member

@primeos primeos commented Oct 4, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@primeos
tdesktop: 1.8.9 -> 1.8.13
c1b1270
@primeos
range-v3: 0.5.0 -> 0.9.1
1038822 
Was too outdated for tdesktop:

/build/source/Telegram/SourceFiles/ui/image/image_prepare.cpp: In function 'QImage Images::BlurLargeImage(QImage, int)':
/build/source/Telegram/SourceFiles/ui/image/image_prepare.cpp:265:81: error: expected primary-expression before ')' token
  265 |  for (auto &&[value, index] : ranges::view::zip(dvs, ints(0, ranges::unreachable))) {
      |                                                                                 ^
@ofborg ofborg bot requested review from abbradar and d-xo October 4, 2019 20:16
@primeos primeos mentioned this pull request Oct 4, 2019
Closed
@abbradar
Copy link
Member

abbradar commented Oct 4, 2019

@GrahamcOfBorg build tdesktop

@abbradar
Copy link
Member

abbradar commented Oct 4, 2019

Ah, didn't notice it's built already.

Thanks!

@abbradar abbradar merged commit 9004c0b into NixOS:master Oct 4, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 5, 2019
@abbradar @dtzWill
Merge pull request NixOS#70414 from primeos/tdesktop
c5d3397 
tdesktop: 1.8.9 -> 1.8.13, range-v3: 0.5.0 -> 0.9.1
(cherry picked from commit 9004c0b)
@d-goldin
Copy link
Contributor

@abbradar @primeos: I'd be interested in having a more recent tdesktop in 19.09. Would this be possible?

@primeos
Copy link
Member Author

primeos commented Oct 23, 2019

@d-goldin sorry, I forgot to reply :o

Usually we mainly backport security updates, but there are sometimes other reasons. I just had a look at the documentation, but the relevant section is pretty short: Stable release branches. If there's a good reason we can consider backporting some updates, but usually that would defy the purpose of the stable branch.

If you want a more recent version it might be best to use tdeskop from another channel like nixos-unstable (unfortunately this will require more storage for the dependencies, but overriding the derivation would result in long compilation times).

@d-goldin
Copy link
Contributor

@primeos: Yeah, agreed. I was just thinking because it felt so outdated for a bit. Yeah, I will consider solving it for me locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

@d-xo d-xo Awaiting requested review from d-xo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@primeos @abbradar @d-goldin