Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oil: 0.7.pre3 -> 0.7.pre5 #70415

Merged
merged 1 commit into from Oct 6, 2019
Merged

oil: 0.7.pre3 -> 0.7.pre5 #70415

merged 1 commit into from Oct 6, 2019

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Oct 4, 2019 •
edited

Motivation for this change

You Can Now Try the Oil Language
Egg Expressions (Oil Regexes)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lheckemann

@ofborg ofborg bot requested a review from lheckemann October 4, 2019 20:25
@lheckemann lheckemann mentioned this pull request Oct 6, 2019
Closed
10 tasks
@lheckemann lheckemann merged commit f523177 into NixOS:master Oct 6, 2019
@dywedir dywedir deleted the oil branch October 6, 2019 11:39
@lheckemann lheckemann mentioned this pull request Oct 7, 2019
Closed
10 tasks
@lheckemann
Copy link
Member

@dywedir @suhr @fjallarefur do you maybe want to add yourselves as maintainers for oil? That way you'll get notified with a review request by @GrahamcOfBorg when someone opens a PR against it :)

@illfygli
Copy link
Contributor

illfygli commented Oct 8, 2019

@lheckemann Sure! I will add myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann Awaiting requested review from lheckemann

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dywedir @lheckemann @illfygli