Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/matomo: fix phpfpm config, add test #70413

Closed
wants to merge 1 commit into from
Closed

nixos/matomo: fix phpfpm config, add test #70413

wants to merge 1 commit into from

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Oct 4, 2019

Motivation for this change

The module was broken since (probably) a30a1e2:

The option `services.phpfpm.pools.matomo.user' is used but not defined.

This commit also switches the module to socket and settings options introduced in 62b774a and 400c6aa.

Test is added to avoid future breakages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @florianjacob @aanderse @mmahut

@mmilata
nixos/matomo: fix phpfpm config, add test
97a59d8 
The module was broken since a30a1e2:

  The option `services.phpfpm.pools.matomo.user' is used but not defined.

This commit also switches the module to `socket` and `settings` options
introduced in 62b774a and 400c6aa.

Test is added to avoid future breakages.
@aanderse
Copy link
Member

aanderse commented Oct 4, 2019

Please collaborate with #69342 as there is overlap/conflict.

@mmilata mmilata closed this Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmilata @aanderse