Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twisted: 18.9.0 -> 19.7.0 #70251

Closed
wants to merge 1 commit into from

Conversation

exarkun
Copy link
Contributor

@exarkun exarkun commented Oct 2, 2019

Motivation for this change

https://github.com/twisted/twisted/blob/d07033a21c7d9146d14ded9d9f94fb4fafb0a4a8/NEWS.rst

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@jonringer
Copy link
Contributor

since this causes 100+ rebuilds, do you mind rebasing this on top of staging and changing the branch to staging? :)

@exarkun
Copy link
Contributor Author

exarkun commented Oct 3, 2019

Seems like a lot of tags. Not sure I understand the workflow for the staging branch.

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@jonringer
Copy link
Contributor

it's because rebasing will make it "seem" that you included all of what diverge in master a little bit until you change the base branch... :(

@jonringer
Copy link
Contributor

jonringer commented Oct 3, 2019

@GrahamcOfBorg eval

hmm, why isn't this re-evaluating

@ofborg ofborg bot removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: printing labels Oct 3, 2019
@FRidh
Copy link
Member

FRidh commented Feb 9, 2020

19.10 is in master

@FRidh FRidh closed this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants