Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twisted: 18.9.0 -> 19.7.0 #70251

Closed
wants to merge 1 commit into from
Closed

twisted: 18.9.0 -> 19.7.0 #70251

wants to merge 1 commit into from
+2 −2

Conversation

exarkun
Copy link
Contributor

@exarkun exarkun commented Oct 2, 2019

Motivation for this change

https://github.com/twisted/twisted/blob/d07033a21c7d9146d14ded9d9f94fb4fafb0a4a8/NEWS.rst

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Sorry, something went wrong.

@exarkun exarkun requested a review from FRidh as a code owner October 2, 2019 13:34
@jonringer
Copy link
Contributor

since this causes 100+ rebuilds, do you mind rebasing this on top of staging and changing the branch to staging? :)

@exarkun
twisted: 18.9.0 -> 19.7.0

Unverified

The email in this signature doesn’t match the committer email.
GPG key ID: 063CCCAD04182D32
Expired
Learn about vigilant mode
ceafed0
@exarkun exarkun force-pushed the twisted-18.9.0->19.7.0 branch from ba22ddf to ceafed0 Compare October 2, 2019 16:16
@exarkun exarkun changed the base branch from master to staging October 2, 2019 16:16
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: printing 6.topic: qt/kde 6.topic: stdenv Standard environment 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 2, 2019
@exarkun
Copy link
Contributor Author

exarkun commented Oct 3, 2019

Seems like a lot of tags. Not sure I understand the workflow for the staging branch.

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@jonringer
Copy link
Contributor

it's because rebasing will make it "seem" that you included all of what diverge in master a little bit until you change the base branch... :(

@jonringer
Copy link
Contributor

jonringer commented Oct 3, 2019 •
edited
Loading

@GrahamcOfBorg eval

hmm, why isn't this re-evaluating

@ofborg ofborg bot removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: printing labels Oct 3, 2019
@ofborg ofborg bot removed 6.topic: qt/kde 6.topic: stdenv Standard environment 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2019
@FRidh
Copy link
Member

FRidh commented Feb 9, 2020

19.10 is in master

@FRidh FRidh closed this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@Ericson2314 Ericson2314

@matthewbauer matthewbauer

@ttuegel ttuegel

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@exarkun @jonringer @FRidh