[client hints] Apply Feature Policy on 3rd party iframe navigations #19464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 2, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1728577
branch
3 times, most recently
from
beceb68
to
05df7af
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1728577
branch
from
05df7af
to
156f818
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1728577
branch
10 times, most recently
from
0a518cc
to
233675a
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1728577
branch
9 times, most recently
from
29b9fb2
to
c42da78
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1728577
branch
from
c42da78
to
ab6afb3
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1728577
branch
12 times, most recently
from
ea68372
to
336b2f1
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1728577
branch
2 times, most recently
from
5cba51f
to
809ee90
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1728577
branch
2 times, most recently
from
138a28a
to
d885373
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1728577
branch
7 times, most recently
from
9171ea8
to
aefab7f
Compare
Feature Policy control over Client Hints in 3rd party contexts currently only works (behind a flag) for subresources. This CL applies that control also over 3rd party iframe navigation requests. On top of that, in order to make this testable with WPTs, this CL also adds a ContentShell persistency layer for Client Hints. Bug: 989898 Binary-Size: Virtual ForTesting method Change-Id: I17ce2af93c9b2f9a3f10972b6b4e0ed8161f9381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728577 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#713469}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1728577
branch
from
aefab7f
to
25fac0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Policy control over Client Hints in 3rd party contexts
currently only works (behind a flag) for subresources.
This CL applies that control also over 3rd party iframe
navigation requests. On top of that, in order to make this testable
with WPTs, this CL also adds a ContentShell persistency layer for
Client Hints.
Bug: 989898
Binary-Size: Virtual ForTesting method
Change-Id: I17ce2af93c9b2f9a3f10972b6b4e0ed8161f9381
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728577
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713469}