Restructure files in common/; add a README.md #19514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #17913 WIP: references to these files have not yet been updated.
16 tasks
The corresponding file was renamed in 0bfaa83
|
I like the new documentation, and I really like the reduction (both the outright deletion of some files and the relocation of others to more specific subdirectories). Renaming the files introduces risk and involves a good deal more people. That will slow the review process, and rightly so. Renaming seems significantly less valuable to me, so I don't think we should move forward in a way that conflates that with the other improvements. What do you think about separating the renames into one or (even better) many dedicated pull requests? |
wpt-pr-bot
requested review from
inexorabletash,
jakearchibald,
jan-ivar,
jdm,
jgraham,
jimsch,
johanneswilm,
kenrussell,
kojiishi,
lilles,
majido,
mkruisselbrink,
mnot,
Ms2ger and
odinho
and removed request for
fmeawad,
foolip,
fred-wang,
FremyCompany,
frivoal,
fserb,
gregwhitworth,
grorg,
halindrome,
hayatoito,
hillbrad and
igrigorik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #17913
References to these files have been updated in subsequent commits.