Ethernet feature gate #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
approved these changes
Oct 4, 2019
Disable ethernet-related features and framing based on a feature gate. Add a no-ethernet option to Travis. notes: - allow(unused) is added when not using ethernet feature - Don't run pretty-print doctest, ethernet is optional.
rubdos
force-pushed
the
ethernet-feature-gate
branch
from
0c9a83a
to
8feda11
Compare
|
Done, and CI approved :-) |
|
@m-labs-homu r+ |
|
📌 Commit 8feda11 has been approved by |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be - as far as I could see - a feature-gate for the Ethernet code.
(cited @whitequark from this comment)
If you see anything I missed that should be behind this feature gate, let me know. I enable Ethernet by default, as to stay backwards compatible.
I still have a bunch of warnings when compiling without
ethernet, which is why I have 8c441c3. If you see how to fix that, always welcome!I hope this is useful for anyone else :-)