Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: fix loading dylibs through gobject on darwin #70304

Merged
merged 1 commit into from Oct 3, 2019
Merged

glib: fix loading dylibs through gobject on darwin #70304

merged 1 commit into from Oct 3, 2019

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Oct 3, 2019 •
edited

Motivation for this change

closes #70300

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 3, 2019
@hedning
Copy link
Contributor Author

hedning commented Oct 3, 2019

@GrahamcOfBorg build gobject-introspection

@ofborg ofborg bot requested review from 7c6f434c and lovek323 October 3, 2019 04:33
@hedning
Copy link
Contributor Author

hedning commented Oct 3, 2019

Think it's safe to merge directly to master here as it mostly fixes already broken builds on darwin (gobject-introspection is about the same rebuild size as glib).

marsam
marsam approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

worldofpeace
worldofpeace approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds on darwin 👍

jtojnar
jtojnar approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From reading https://gitlab.gnome.org/GNOME/glib/issues/1887, it should be okay.

@worldofpeace worldofpeace merged commit f91f506 into NixOS:master Oct 3, 2019
@hedning hedning deleted the glib-fix-loading-dylibs branch October 3, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@marsam marsam marsam approved these changes

@jtojnar jtojnar jtojnar approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gobject-introspection broken on darwin
4 participants
@hedning @marsam @jtojnar @worldofpeace