Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qutebrowser: 1.7.0 -> 1.8.1 #70303

Merged
merged 1 commit into from Oct 3, 2019
Merged

qutebrowser: 1.7.0 -> 1.8.1 #70303

merged 1 commit into from Oct 3, 2019

Conversation

ebzzry
Copy link

@ebzzry ebzzry commented Oct 3, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ x NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jagajaga @rnhmjoj

@ofborg ofborg bot requested review from rnhmjoj and jagajaga October 3, 2019 04:27
@veprbl
Copy link
Member

veprbl commented Oct 3, 2019

@GrahamcOfBorg build qutebrowser

jonringer
jonringer approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable works
double wrapped (but 1 is python app, and other is GApp + Qt wrap, which is expected)

[4 built, 43 copied (133.3 MiB), 33.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70303
1 package were build:
qutebrowser

although the closure size is a little on the big size, i know it exports gtk + qt, but.... jesus

$ nix path-info -Sh ./results/qutebrowser
/nix/store/d8yq7265z13iihj1g58zkmsiwyh0b14b-qutebrowser-1.8.1      1.6G

but I don't consider it a regression, as master is also very large:

$ nix path-info -Sh ./result
/nix/store/mn89yl08x3s1gr4n7ffzm2asinzf8kxw-qutebrowser-1.7.0      1.6G

@jonringer jonringer merged commit 57c43ad into NixOS:master Oct 3, 2019
@ebzzry
Copy link
Author

ebzzry commented Oct 3, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@rnhmjoj rnhmjoj Awaiting requested review from rnhmjoj

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ebzzry @veprbl @jonringer