Revert to prevous ordering of TCP options #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…specified in the spec,some implementations expect some ordering (unforntunately I have found one that does, and blocks outbound packets due to 'invalid tcp options')
|
cc @jhwgh1968 |
|
Interesting. I don't think that should cause a problem... (If you were waiting on me, sorry for delaying your PR. I have updated my GitHub status to reflect my current plans.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't change anything for spec compliant routers, infact, the options used to be in the order, see unfortunately I've found a router that blocks my packets unless mss is sent first (very annoying bug to find).