Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spring-boot: init at 2.1.9 #70282

Merged
merged 1 commit into from Oct 12, 2019
Merged

spring-boot: init at 2.1.9 #70282

merged 1 commit into from Oct 12, 2019

Conversation

moaxcp
Copy link
Contributor

@moaxcp moaxcp commented Oct 2, 2019 •
edited by jonringer

Motivation for this change

Adding spring-boot cli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable appears to work

[3 built, 28 copied (265.4 MiB), 93.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70282
1 package were build:
spring-boot

[nix-shell:~/.cache/nix-review/pr-70282]$ nix path-info -Sh ./results/spring-boot
/nix/store/2znr28c2p56z9hpbdj7cckzb7wa0zwav-spring-boot-2.1.8    483.5M

@jonringer
Copy link
Contributor

@GrahamcOfBorg build spring-boot

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/66

c0bw3b
c0bw3b reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2.1.9 has been published in the meantime.

pkgs/development/tools/spring-boot/default.nix Show resolved Hide resolved
pkgs/development/tools/spring-boot/default.nix Show resolved Hide resolved
pkgs/development/tools/spring-boot/default.nix Show resolved Hide resolved
@moaxcp moaxcp changed the title spring-boot: init at 2.1.8 spring-boot: init at 2.1.9 Oct 11, 2019
@moaxcp
Copy link
Contributor Author

moaxcp commented Oct 11, 2019

I updated to 2.1.9

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 12, 2019

@GrahamcOfBorg build spring-boot

c0bw3b
c0bw3b approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 70282 1

1 package were build:
  • spring-boot
$ ./results/spring-boot/bin/spring shell
Spring Boot (v2.1.9.RELEASE)
Hit TAB to complete. Type 'help' and hit RETURN for help, and 'exit' to quit.

$ version
Spring CLI v2.1.9.RELEASE
$ encodepassword mysecret
{bcrypt}$2a$10$/SM56QEHnD3FTwoI18zv2eH.ZPrIHlrXtySof7iijwzQ.9vqO6acu

@c0bw3b c0bw3b merged commit f5cc5ce into NixOS:master Oct 12, 2019
@moaxcp moaxcp deleted the spring-boot branch October 12, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@moaxcp @jonringer @nixos-discourse @c0bw3b