Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] gst-plugins-base: apply patch for CVE-2019-9928 #70284

Closed
wants to merge 1 commit into from
Closed

[19.09] gst-plugins-base: apply patch for CVE-2019-9928 #70284

wants to merge 1 commit into from

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Oct 2, 2019

Motivation for this change

Refactor the patchPhase management for the package along the way to
something more standard.

#70097 (security bug)
Master PR: #70283

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth
gst-plugins-base: apply patch for CVE-2019-9928
943e625 
Refactor the patchPhase management for the package along the way to
something more standard.

(cherry picked from commit ebeb9ab51fe850b0967cf22f7c4681102e9646e6)
@ofborg ofborg bot requested a review from lovek323 October 2, 2019 21:57
@FRidh FRidh changed the title gst-plugins-base: apply patch for CVE-2019-9928 [19.09] [19.09] gst-plugins-base: apply patch for CVE-2019-9928 Oct 24, 2019
@vcunat vcunat self-assigned this Nov 9, 2019
vcunat pushed a commit that referenced this pull request Nov 9, 2019
@delroth @vcunat
gst-plugins-base: apply patch for CVE-2019-9928
0704d51 
(cherry-picked from a92c42d and 832f46a)
Fixes #70097, closes PR #70284.
@vcunat
Copy link
Member

vcunat commented Nov 9, 2019

Cherry-picked; the commit message referred to a rebased commit anyway.

@vcunat vcunat closed this Nov 9, 2019
hax404 pushed a commit to hax404/nixpkgs that referenced this pull request Nov 13, 2019
@delroth @hax404
gst-plugins-base: apply patch for CVE-2019-9928
2d56259 
(cherry-picked from a92c42d and 832f46a)
Fixes NixOS#70097, closes PR NixOS#70284.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees

@vcunat vcunat

Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @vcunat @veprbl