Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gst-plugins-base: apply patch for CVE-2019-9928 #70283

Merged
merged 1 commit into from Oct 24, 2019
Merged

gst-plugins-base: apply patch for CVE-2019-9928 #70283

merged 1 commit into from Oct 24, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Oct 2, 2019

Motivation for this change

Refactor the patchPhase management for the package along the way to
something more standard.

#70097 (security bug)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth
gst-plugins-base: apply patch for CVE-2019-9928
97e4a11 
Refactor the patchPhase management for the package along the way to
something more standard.
This was referenced Oct 2, 2019
Closed
Merged
@ofborg ofborg bot requested a review from lovek323 October 2, 2019 21:53
@FRidh
Copy link
Member

FRidh commented Oct 22, 2019

@GrahamcOfBorg build gst-plugins-base

@FRidh FRidh changed the base branch from staging-next to staging October 24, 2019 06:53
@FRidh FRidh merged commit a92c42d into NixOS:staging Oct 24, 2019
vcunat added a commit that referenced this pull request Nov 9, 2019
@vcunat
gst-plugins-base: use fetchpatch for better hash stability
832f46a 
/cc original PR #70283.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @FRidh @veprbl