Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] corebird: drop discontinued package and replace with cawbird #70287

Closed
wants to merge 4 commits into from
Closed

[backport] corebird: drop discontinued package and replace with cawbird #70287

wants to merge 4 commits into from

Conversation

schmittlauch
Copy link
Member

backport of #70168

Additionally, a deprecation notice has been added to the release-19.09 release notes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@schmittlauch
cawbird: init at 1.0.1
9c9fdac 
Cawbird is a fork of the discontinued Corebird Twitter client.

Co-Authored-By: Jon <jonringer@users.noreply.github.com>
(cherry picked from commit e1c7d20)
@schmittlauch
corebird: drop package due to discontinuation, recommend cawbird as…
4ee8926 
… alternative

(partly cherry picked from commit f855e58)

also added a note the release-19.09 release notes
@schmittlauch schmittlauch mentioned this pull request Oct 2, 2019
Merged
10 tasks
@schmittlauch
Copy link
Member Author

@Lassulus It'd be nice to get this merged before the 19.09 release

@schmittlauch
Copy link
Member Author

@GrahamcOfBorg build cawbird

@worldofpeace
Copy link
Contributor

cc @jtojnar as this techincally conflicts with what we've done in for gnome-3.34

@schmittlauch
Copy link
Member Author

Do we need to get rid of the corebird attr in aliases.nix?

@worldofpeace
Copy link
Contributor

Do we need to get rid of the corebird attr in aliases.nix?

No, the throw you added to all-packages.nix belongs in aliases.nix.
See

nixpkgs/pkgs/top-level/aliases.nix

Line 33 in d33e497

### Deprecated aliases - for backward compatibility

@worldofpeace
Copy link
Contributor

Ah wait this is a backport.
Sorry for the confusion @schmittlauch.
I guess we should fix what's on master first.

@schmittlauch
Copy link
Member Author

@worldofpeace So what to do then? Revert the merge of #70168, fix the PR and then backport it + the release notes?

@worldofpeace
Copy link
Contributor

@worldofpeace So what to do then? Revert the merge of #70168, fix the PR and then backport it + the release notes?

The release notes and the alias fix need to be on master.
So I recommend closing this an opening a PR to master.
I'll then backport all the commits manually 👍

@schmittlauch
Copy link
Member Author

@worldofpeace Can you revert the merged master PR for me or shall I create a revert PR?

@ofborg ofborg bot requested a review from jonafato October 2, 2019 22:28
@worldofpeace
Copy link
Contributor

@worldofpeace Can you revert the merged master PR for me or shall I create a revert PR?

I'm not sure what needs to be reverted?
We just need a commit to move the throw to aliases.nix and another for a release note.

@schmittlauch
Copy link
Member Author

@worldofpeace I thought that reverting the merge of #70168, then fixing it with the alias and release notes and merging it again, might be clenaer then just creating a 2nd PR.

But if I have your ok for just doing the fixes in an additional PR I'll go for that.

@worldofpeace
Copy link
Contributor

But if I have your ok for just doing the fixes in an additional PR I'll go for that.

Yeah that's typically fine 👍

@schmittlauch schmittlauch mentioned this pull request Oct 2, 2019
Merged
@worldofpeace
Copy link
Contributor

backported in 8349643 b919677 5e0b687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@jonafato jonafato Awaiting requested review from jonafato

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: clean-up 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schmittlauch @worldofpeace