Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gst-plugins-base,gst_all_1.gst-plugins-base: apply patch for CVE-2019-9928 [19.03] #70285

Merged
merged 1 commit into from Oct 13, 2019
Merged

gst-plugins-base,gst_all_1.gst-plugins-base: apply patch for CVE-2019-9928 [19.03] #70285

merged 1 commit into from Oct 13, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Oct 2, 2019

Motivation for this change

Refactor the patchPhase management for the package along the way to
something more standard.

Note that 19.03 needs an extra patch since the 1.x version it carries is also impacted (not the case for 19.09 / master).

#70097 (security bug)
Master PR: #70283

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth
gst-plugins-base,gst_all_1.gst-plugins-base: apply patch for CVE-2019…
061663a 
…-9928

Refactor the patchPhase management for the package along the way to
something more standard.

(Cherry pick from 97e4a11 with an extra
version of the package to patch in 19.03.)
@ofborg ofborg bot requested review from lovek323 and matthewbauer October 2, 2019 22:10
@vcunat vcunat self-assigned this Oct 13, 2019
vcunat added a commit that referenced this pull request Oct 13, 2019
@vcunat
Merge #70285: *gst-plugins-base: patch CVE-2019-9928
139e21b 
...into staging-19.03
@vcunat vcunat merged commit 061663a into NixOS:staging-19.03 Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

@vcunat vcunat

Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @vcunat @veprbl