Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/gnome3: copy gnome-shell override #70362

Merged
merged 1 commit into from Oct 5, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 4, 2019

Motivation for this change

Without this these default settings overrides to gnome-shell
don't appear to be used completely.

I believe this might have been an issue since 3.32, so we should backport this change.

Things done

The most obvious thing you can check for is that edge-tiling and dynamic-workspaces won't be enabled.

With this change I verified the settings from the override appear to be used.

[org.gnome.mutter:GNOME]
attach-modal-dialogs=true
edge-tiling=true
dynamic-workspaces=true
workspaces-only-on-primary=true
focus-change-on-pointer-rest=true
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Without this these default settings overrides to gnome-shell
don't appear to be used completely.
@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 4, 2019
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This have indeed been a problem at least from 3.32. LGTM

@worldofpeace worldofpeace merged commit 1f91fd0 into NixOS:master Oct 5, 2019
@worldofpeace worldofpeace deleted the gnome-shell-overides branch October 5, 2019 02:53
@worldofpeace
Copy link
Contributor Author

backported in 6a35f11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 8.has: module (update) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants