Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sourcehut.*: 2019.10.02 #70255

Merged
merged 13 commits into from Oct 9, 2019
Merged

sourcehut.*: 2019.10.02 #70255

merged 13 commits into from Oct 9, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Oct 2, 2019 •
edited

Builds after #69066 or should build after #70256 as well.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@veprbl
Copy link
Member

veprbl commented Oct 2, 2019

nix-review reports:

hash mismatch in fixed-output derivation '/nix/store/yh6zl469vskrayxbh6c02r8rmbc9rv33-aaeb7076e5acb045880b46155014c0640624797e.patch':
  wanted: sha256:0r6g6pvb39vzci8g67mv9rlrvavqvfz6vlv8988wv53bpz1mss3p
  got:    sha256:0l420cmk7469wgb1xq2rxinvja1f2brb5cm4smj2s2wqgymbrf6h
cannot build derivation '/nix/store/nmacmyvndqib53khgzy2w0pvknv8mnjx-python3.7-asyncpg-0.18.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ppps8jbsnfkibvnvrsnw89w4b6m5ab3g-python3.7-listssrht-0.38.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/v16x8ra446rbv0zkarhqq0kr0mwx598b-env.drv': 1 dependencies couldn't be built
[30 built (1 failed), 313 copied (1295.8 MiB), 288.8 MiB DL]
error: build of '/nix/store/v16x8ra446rbv0zkarhqq0kr0mwx598b-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/70255
1 package failed to build:
sourcehut.listssrht

9 package were build:
sourcehut.buildsrht sourcehut.dispatchsrht sourcehut.gitsrht sourcehut.hgsrht sourcehut.mansrht sourcehut.metasrht sourcehut.pastesrht sourcehut.python sourcehut.todosrht

@eadwu
Copy link
Member Author

eadwu commented Oct 2, 2019

That's an unrelated issue to sourcehut, it's due the hash of the patch from Github being changed, it's fixed by the #70256.

@veprbl
Copy link
Member

veprbl commented Oct 3, 2019

@GrahamcOfBorg eval

@Ma27
Copy link
Member

Ma27 commented Oct 4, 2019

You may want to rebase from master as sourcehut is currently marked as broken there since #70256.

@matthiasbeyer
Copy link
Contributor

Why does sourcehut require node anyways? Isn't it one of the selling points of sourcehut that it runs without JS?

@eadwu
Copy link
Member Author

eadwu commented Oct 5, 2019 •
edited

It looks like it's just for minifying files, it doesn't require node, but uses npm to download clean-css.

@eadwu
Copy link
Member Author

eadwu commented Oct 5, 2019

Specifically, it's called when generating the static sources I'm pretty sure [1].

[1] https://git.sr.ht/~sircmpwn/core.sr.ht/tree/master/srht/Makefile#L25

@eadwu
Copy link
Member Author

eadwu commented Oct 5, 2019

Reupdated and rebased to master.

@veprbl
Copy link
Member

veprbl commented Oct 6, 2019

@GrahamcOfBorg build sourcehut.gitsrht sourcehut.mansrht sourcehut.hgsrht sourcehut.todosrht sourcehut.dispatchsrht sourcehut.pastesrht sourcehut.buildsrht sourcehut.listssrht sourcehut.metasrht

@veprbl veprbl merged commit a7b3728 into NixOS:master Oct 9, 2019
@eadwu eadwu deleted the sourcehut/update-1 branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eadwu @veprbl @Ma27 @matthiasbeyer