Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] beets: use new essentia package for absubmit plugin #70392

Closed
wants to merge 5 commits into from
Closed

[WIP] beets: use new essentia package for absubmit plugin #70392

wants to merge 5 commits into from

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 4, 2019 •
edited

Motivation for this change

Add support for the absubmit plugin which depends on a new package
essentia added in #70389 . Merging this depends upon #70389 which in
turn depends upon #70372.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @aszlig @domenkozar @pjones

@doronbehar
Expand checkInputs with deps for plugins
a4eb5c3 
If a user overrides the beets package using an overlay in his config
(using overlays for example), he might disable several built-in plugins
and some their tests will fail.
@doronbehar
Add support for absubmit plugin using essentia
5ec290f 
Using essentia (NixOS#70389), it's possible to enable the absubmit plugin.
@doronbehar
Fix indentation
4350105
@doronbehar doronbehar changed the title ###### Motivation for this change beets: Add support for absubmit plugin Oct 4, 2019
@doronbehar
Copy link
Contributor Author

Sorry for the wrong title @aszlig @domenkozar @pjones, I hope the intention is clear now.

@ofborg ofborg bot requested review from pjones, domenkozar and aszlig October 4, 2019 12:40
doronbehar and others added 2 commits October 4, 2019 16:31
@doronbehar @aszlig
Improve a checkInputs' comment's phrasing
4bbb6aa 
Co-Authored-By: aszlig <aszlig@redmoonstudios.org>
@doronbehar @aszlig
Run sed commands consistently
c7da4dc 
Co-Authored-By: aszlig <aszlig@redmoonstudios.org>
@ofborg ofborg bot requested a review from aszlig October 4, 2019 13:44
@aszlig
Copy link
Member

aszlig commented Oct 4, 2019 •
edited

@doronbehar: Thanks for your pull request, testing and merging... Depends on #70389 and #70372, will look at that PR later and merge + test this PR afterwards.

@aszlig aszlig mentioned this pull request Oct 4, 2019
Closed
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/71

@doronbehar doronbehar changed the title beets: Add support for absubmit plugin [WIP] beets: use new essentia package for absubmit plugin Feb 29, 2020
@doronbehar
Copy link
Contributor Author

Closing this as absubmit is functional now, It would be nice to use the real essentia package (#70389) but it'll be more proper I guess to switch to using it in beets once it'll be packaged..

@doronbehar doronbehar closed this Mar 31, 2020
@doronbehar doronbehar deleted the improve-beets branch December 18, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aszlig aszlig aszlig approved these changes

@pjones pjones Awaiting requested review from pjones

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
0.kind: enhancement 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @aszlig @nixos-discourse