Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome 3.34 #68608

Merged
merged 197 commits into from Oct 2, 2019
Merged

Gnome 3.34 #68608

merged 197 commits into from Oct 2, 2019

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Sep 12, 2019

Jobset Evals

as of 2019-09-20
https://hydra.nixos.org/eval/1543560?compare=1542887

Blocking issues
TODO
Nice to have
Things done

I've gotten my own system up and running without any major issues :)

closes #68318

@worldofpeace
Copy link
Contributor

Was there a hydra jobset setup for the previous gnome branch? (I think it was called that)

@hedning
Copy link
Contributor Author

hedning commented Sep 12, 2019

Yeah, https://hydra.nixos.org/jobset/nixpkgs/gnome#tabs-configuration, it just needs to be set to target this branch.

@worldofpeace
Copy link
Contributor

cc @domenkozar @vcunat @NixOS/infra as we need the jobset reconfigured with gnome-3.34 as the target branch.

@zimbatm
Copy link
Member

zimbatm commented Sep 13, 2019

@worldofpeace done

@hedning
Copy link
Contributor Author

hedning commented Sep 15, 2019

atk caused some issues for a few dependencies as the pc file no longer Requires gobject. I added both glib and gobject as the patch was easier that way, and it shouldn't really be a problem as gobject itself require glib.

@hedning
Copy link
Contributor Author

hedning commented Sep 15, 2019

In grilo I dropped the meson_options patch as it no longer applied, not sure if did anything important? (the vapi stuff was included in the output at least)

@jtojnar
Copy link
Contributor

jtojnar commented Sep 15, 2019

I will try to take a look during the working week.

BTW, I added a commit parsing to the changelog obtainer: https://github.com/jtojnar/what-changed#commits

@worldofpeace
Copy link
Contributor

worldofpeace commented Sep 15, 2019

It's easy to enable and works OK, but it looks like there's some environment trobles (eg. I'm getting the wrong fonts/theme etc.)

Is it possible you could try with the commits from #68492 @hedning?

About realtime scheduling #68318 (comment): i believe what you've suggested there is #68608?
It's the same sort of thing I did for gnome-keyring

And the situation with GDM and rebuild switch.
The upstream unit appears to have

Conflicts=getty@tty1.service # number varies as to what's configured at buildtime
After=getty@tty1.service

Relevant?

@hedning
Copy link
Contributor Author

hedning commented Sep 16, 2019

Is it possible you could try with the commits from #68492 @hedning?

Yeah, can give it a go

Seahorse doesn't build with the new libsecret btw.

Relevant?

Yeah, testing this in a few configurations:

  • starting gdm on tty1 and waiting for tty1 works, apart from nixos-rebuild switching (which might be unrelated X11 crash at end of nixos-rebuild switch --upgrade #44344)
  • starting gdm on tty7 and waiting for tty1 also works for some reason, but it broke gnome-shell after switching to a console and back (no idea if that's reproducible)
  • starting gdm on tt7 and waiting on tty7 results in a tty jump when the gnome-session starts.

I'd say we should go for tty1 and declare the conflict (as upstream does), though I guess we should look out for the rebuild issue: #21439 4a180da c46d4da

@hedning
Copy link
Contributor Author

hedning commented Sep 16, 2019

systemd session doesn't start gsd properly. This causes a bunch of problems like not picking up the correct theme etc. gsd in systemd.packages isn't sufficient for some reason though. Will investigate some more.

@worldofpeace
Copy link
Contributor

Seahorse doesn't build with the new libsecret btw.

Don't know why there isn't a new release yet, I've updated to git master in the meantime.
There's also https://gitlab.gnome.org/GNOME/seahorse/issues/244 which I guess we would've bumped into.

@hedning
Copy link
Contributor Author

hedning commented Sep 16, 2019

Failed build log of webkitgtk 2.26.0: 8b72d19:

lib/libWTFGTK.a(lib/../Source/WTF/wtf/CMakeFiles/WTF.dir/MediaTime.cpp.o):MediaTime.cpp:function WTF::MediaTime::setTimeScale(unsigned int, WTF::MediaTime::RoundingFlags): error: undefined reference to '__divmodti4'
collect2: error: ld returned 1 exit status

Not sure how to fix this (and the error occurs really late in the build annoyingly enough :(

@worldofpeace
Copy link
Contributor

I've enabled mutter's profiler f1eb683, this needed a little patch. Haven't got to submitting it because GitLab seems to be having a hard time forking mutter for me 😄

worldofpeace and others added 15 commits October 3, 2019 00:09
Without this GNOME_SESSION_DEBUG
likely won't be set in the systemd user environment.
This should no longer be necessary as gnome-shell ships its own on-screen
keyboard.
Fixes some eg. animation related crashes which in particular affected
dash-to-dock.
It is just a few patches only needed by termite. Let's not pollute our tree with it.
This includes commands to spamassassin, sa-learn, bogofilter
and the prefix to openldap
There's still no official release for gnome-3.34
@jtojnar jtojnar merged commit 4655669 into master Oct 2, 2019
GNOME automation moved this from Ready to Done Oct 2, 2019
@jtojnar jtojnar deleted the gnome-3.34 branch October 2, 2019 22:38
@jtojnar
Copy link
Contributor

jtojnar commented Oct 2, 2019

Past merge times:

@worldofpeace
Copy link
Contributor

worldofpeace commented Oct 2, 2019

So I've added a GitHub project for the next release ahead of time

Organizationally, I don't find it convenient for us to edit the issue when there's GitHub projects for this.

It also avoids questions from observers like "what's the status of this?" when everything is tracked on GitHub.

@felschr
Copy link
Member

felschr commented Oct 21, 2019

So, as a NixOS newbie can someone tell me if / how I can update to GNOME 3.34 from nixos-unstable when I'm running 19.09?

@hedning
Copy link
Contributor Author

hedning commented Oct 21, 2019

@felschr your best bet is running nixos-unstable to be honest, it's quite stable tbh, and if something actually breaks there's rollback :)

With nix-channel you should be able to switch like this:

nix-channel --add https://nixos.org/channels/nixos-unstable nixos
nixos-rebuild boot --upgrade

If you want some more manual control, you can build from a checked out git repo (the channels remote , git://github.com/NixOS/nixpkgs-channels.git, reflects the revision you get with nix-channel):

cd ~/path/to/nixpkgs
git checkout channels/nixos-unstable # or whatever commit you want :)
nixos-rebuild boot -I nixpkgs=./.

Hope that helps :)

@jtojnar
Copy link
Contributor

jtojnar commented Oct 21, 2019

@felschr unfortunately, desktop apps often depend on many systemd/D-Bus services, and since those environments only supports a single namespace, it would conflict with your running system (unless you used some kind of ultra-minimal configuration). For that reason there is no supported way to run GNOME 3.34 on 19.09.

I suggest you switch your whole system to nixos-unstable, despite the name it is quite stable, since we require tests to pass before bumping the channel.

@felschr
Copy link
Member

felschr commented Oct 21, 2019

@jtojnar Thank you for the quick answer and insightful explanation.
I'll consider making the channel switch.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixos-20-03-feature-freeze/5655/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
GNOME
  
Done
Development

Successfully merging this pull request may close these issues.

Update to gnome-3.34
9 participants